Bug#1041327: RFS: libtypec/0.3-1 [RFP] -- Development files for an interface for USB-C port management
Hi Colin,
There are a few upstream source files licensed under GPL.
Please update debian/copyright to cover all the used licenses.
You can run 'cme update dpkg-copyright' in the source directory or any
other tool from https://wiki.debian.org/CopyrightReviewTools to help with
the manual labor.
Cheers,
Balint
On 2023. Nov 15., Wed at 10:27, Bálint Réczey <balint@balintreczey.hu>
wrote:
> Hi Colin,
>
> Colin King (gmail) <colin.i.king@gmail.com> ezt írta (időpont: 2023.
> nov. 14., K, 17:58):
> >
> > Hi Balint,
> >
> > I've uploaded 0.4.0-2 with the suggested fixes.
> >
> > reply inlined below:
> >
> > On 09/11/2023 16:23, Bálint Réczey wrote:
> > > Hi Colin,
> > >
> > > Colin King (gmail) <colin.i.king@gmail.com> ezt írta (időpont: 2023.
> > > nov. 7., K, 15:18):
> > >>
> > >> Hi Balint,
> > >>
> > >> Thanks for responding with the review. I was waiting for the upstream
> > >> project to release a 0.4 with some minor fixes before re-uploading to
> > >> mentors.
> > >>
> > >> I've addressed the issues you found as below:
> > >
> > > Please see my observations below.
> > >
> > >> On 22/10/2023 22:38, Bálint Réczey wrote:
> > >>> Hi Colin,
> > >>>
> > >>> I've checked the second upload at [1].
> > >>> As you can see in the Lintian warnings there is a .git directory
> which
> > >>> is not ideal for a source package.
> > >>> I suggest using the most widely used git-buildpackage based workflow
> > >>> where the gbp command takes care of exporting the source package
> > >>> without the .git dir from the packaging repository.
> > >>> I'd be happy to set up a packaging repo for you at
> > >>> https://salsa.debian.org/debian/libtypec and add you as a maintainer
> > >>> as described in [2]
> > >
> > > I still hold up my offer about setting up a git repo for packaging on
> > > Salsa. That comes with the benefit of automated fixes from Debian
> > > Janitor and I could also comment on changes right where they happened
Reply to: