Hi, On 11 Nov 2023 at 18:07:24, Tobias Frost wrote: Thanks very much for reviewing the package. > On Thu, Oct 26, 2023 at 12:24:13AM +0100, Carles Pina i Estany wrote: > > Package: sponsorship-requests > > Severity: wishlist > > > > * Package name : qnetload > > Version : 1.3.6-1 > > (Review of Upload #3 Uploaded: 2023-10-25 23:09) > > - autopkgtests: thanks for having one, but this test should be marked > superficicial. Done: https://salsa.debian.org/carlespina/qnetload/-/commit/5382611266f7481650cdd74522aca783f59b0c88 > (optional: For a non superficial test, you could run your test suite > in autopkgtest.) I think that I will skip this for now. I would like to run, in autopkgtest, a proper integration test that tests /usr/bin/qnetload (those tests do not exist yet), instead of building the unit tests in autopkgtest and running them (it's done in the build step). I will check the options for the future. I might get in touch in a relevant mailing list or to you to share some thoughts. > - d/copyright should have the complete license boiler plate for GPL-3 Oops, thanks, and I will ammend somewhere else (another package) where I also missed that. https://salsa.debian.org/carlespina/qnetload/-/commit/0afc0046d3fd8ad251a35e6b2b3983f46575bf88 > Otherwise, package looks good. Please fix those two issues and I'll upload. Excellent! I've also updated debian/changelog timestamp: https://salsa.debian.org/carlespina/qnetload/-/commit/44b25c13490c6010b5d26e444c58d144a83ab17d New build: https://mentors.debian.net/package/qnetload/: Upload #4 Uploaded: 2023-11-12 00:55 https://mentors.debian.net/debian/pool/main/q/qnetload/qnetload_1.3.6-1.dsc > Remove the moreinfo tag when ready! Will do! -- Carles Pina i Estany https://carles.pina.cat
Attachment:
signature.asc
Description: PGP signature