Bug#1041327: RFS: libtypec/0.3-1 [RFP] -- Development files for an interface for USB-C port management
Hi Colin,
I've checked the second upload at [1].
As you can see in the Lintian warnings there is a .git directory which
is not ideal for a source package.
I suggest using the most widely used git-buildpackage based workflow
where the gbp command takes care of exporting the source package
without the .git dir from the packaging repository.
I'd be happy to set up a packaging repo for you at
https://salsa.debian.org/debian/libtypec and add you as a maintainer
as described in [2]
Other observations regarding the packaging:
* There is debian/install and also there are binary package specific
*.install files which is slightly confusing.
I suggest dropping debian/install.
* In the debian/*.install files you need to specify only the target
dir, not the target file.
In libtypec-dev
/usr/share/pkgconfig/${DEB_HOST_MULTIARCH}/libtypec.pc/libtypec.pc
gets shipped, which is not desired.
* libtypec.h seems to be the same on all architectures. Does it have
to be shipped in a multiarch include location?
* Binary packages in debian/control are not marked as Multi-Arch: same
* Please target experimental. The package needs to pass NEW and to
migrate to testing it will need a new source-only upload anyway.
Cheers,
Balint
[1] https://mentors.debian.net/package/libtypec/
[2] https://wiki.debian.org/Salsa/Doc#Collaborative_Maintenance:_.22Debian.22_group
On Thu, 3 Aug 2023 17:00:58 +0100 "Colin King (gmail)"
<colin.i.king@gmail.com> wrote:
> Hi,
>
> I've uploaded a fixed package that addresses these issues.
>
> Colin
>
> On 18/07/2023 08:50, Adam Borowski wrote:
> > On Mon, Jul 17, 2023 at 03:29:13PM +0100, Colin King (gmail) wrote:
> >> * Package name : libtypec
> >> Version : 0.3-1
> >> * URL : https://github.com/Rajaram-Regupathy/libtypec
> >
> >> libtypec1 - generic interface for efficient USB-C port management
> >> libtypec-dev - Development files for an interface for USB-C port management
> >
> >> libtypec (0.3-1) unstable; urgency=low
> >> .
> >> * Initial release (Closes: #1023477)
> >> * Add patch 0001-fix-libtypec-so-version.patch to fix .so name version
> >
> > Hi!
> > Before doing manual review, let's start with lintian:
> >
> > E: libtypec1: pkg-config-multi-arch-wrong-dir full text contains architecture specific dir x86_64-linux-gnu [usr/share/pkgconfig/libtypec.pc]
> > W: libtypec-dev: empty-binary-package
> > W: libtypec1: lacks-unversioned-link-to-shared-library example: usr/lib/x86_64-linux-gnu/libtypec.so [usr/lib/x86_64-linux-gnu/libtypec.so.0.3.0]
> > W: libtypec1: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libtypec.so.0.3.0 [usr/lib/x86_64-linux-gnu/libtypec.so]
> >
> >
> > Meow!
>
>
>
Reply to: