Hi Sean, Thanks for your comments. Replies are inline below. Sean Whitton <spwhitton@spwhitton.name> writes: > Hello, > > On Sun 15 Oct 2023 at 05:14am -07, Xiyue Deng wrote: > >> Sure! It's at https://salsa.debian.org/manphiz/bison-mode. FYI I have >> also filed an RFS bug#1053987. > > Alright, pushed that to a team repo, let's work from there. > Thanks! Pushed the new changes with detailed below. > Review of 8123e6e09fa1591dc2182682661421d9be80c328: > > - d/copyright is required to say where upstream sources were obtained -- > see Debian Policy > Added in the `Source' field. Also added upstream maintainer to the `Upstream-Contact' field. > - It looks like you made up the copyright statement for Wilfred Hughes, > right? > > While he may indeed hold copyright, what the GPL requires is just that > we reproduce the copyright notices we actually find in the source. > So it's probably best to drop it for now, and consider offering a pull > request upstream. > Ah I see. So for d/copyright we need to stick to the source information. Dropped Wilfred from the list of copyright holders for now. Also opened a PR upstream for tracking[1]. > - I'd like to suggest dropping the .gitignore, because it interferes > with me uploading using dgit. Can explain more if you want. > Got it. Also dropped ".gitignore". > - description "electric support" is ambiguous. Support for doing what? > It should have been "electric indentation". Fixed now. > - in general, do you mind if when I upload I commit the 'dch -r' change > for you? I.e. the upload is signed off by me, but there'd be [ Xiyue > Deng ] in the changelog. This avoids an e-mail roundtrip. Totally up > to you. As this is the first time I attempt of ITP/RFS, I'd like to go over the steps for packaging as much as possible if OK. But AIUI this package will need to go through the NEW queue, so I guess if you sponsor my upload to mentors.d.n it may require some extra steps, then I'm OK if what you propose can save some trouble. Thanks! [1] https://github.com/Wilfred/bison-mode/issues/15 -- Xiyue Deng
Attachment:
signature.asc
Description: PGP signature