Bug#1032372: RFS: heart/0.1-2 [ITP] -- Card game about avoiding having to take rounds

[Tobias Frost <tobi@debian.org>]

Package: sponsorship-requests
Followup-For: Bug #1032372
Control: tags -1 moreinfo

Hi Benedikt,

here's a review on hearts:

Disclaimer: I'm not a Java packager, I do not intend to sponsor this package

- d/changelog
  - Initial uploads have only a single entry, "Initial release (Closes #YOUR_ITP_BUG).
    and debian revision must be -1

- d/control
  - It seems that you should B-D on default-jdk[1, §2.2], at least it should be the first alternative
  - Vcs-Git/Vcs-Browae is missing.

- d/rules should be updated to modern debhelper format, seeh dh(1) for examples.
  - do you need javahelper? [1, §2.2]
  - cleaning should be done with d/clean

- d/watch is missing.

- d/upstream/metadata is missing.

- lintian emits those, please investigate:
    W: heart source: no-debian-changes
    I: heart source: debian-watch-file-is-missing
    I: heart source: out-of-date-standards-version 4.6.1.0 (released 2022-05-11) (current is 4.6.2)
    X: heart source: upstream-metadata-file-is-missing

- please consider to put the package in team maintaince, e.g the games-team.

-- 
Cheers,
tobi

[1] https://www.debian.org/doc/packaging-manuals/java-policy/ch02.html