Bug#1012286: RFS: zig/0.9.1-1 [ITP] -- Programming language
Hi Nick,
Thanks for draft package. Let's go for 0.9 and when that is in we'll see what version can be packaged next.
I have reopened Thr RFS bug. Please have that in copy during the discussion so other sponsors can pick up if I am not
repsonsive.
In general it is a good idea to put your package in a repo on Debian's salsa git service because that has a CI system
with a working setup to build Debian packages. You would then have to put the files that are in your repository's root
into a debian directory. With the CI in place you will get an idea of the quality of your package before posting it for
review.
d/rules
=======
You should leave the CMAKE_BUILD_TYPE default because this will build the debug info that will then be extracted and
stripped by default.
Your package fails to build from scratch on amd64 with a test fail (maybecaused by wrong pwd?):
[100%] Built target zig
make[2]: Leaving directory '/home/bage/zig-0.9.1/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_start /home/bage/zig-0.9.1/obj-x86_64-linux-gnu/CMakeFiles 0
make[1]: Leaving directory '/home/bage/zig-0.9.1/obj-x86_64-linux-gnu'
debian/rules override_dh_auto_test
make[1]: Entering directory '/home/bage/zig-0.9.1'
./debian/zig/usr/bin/zig build test-fmt || exit 1; ./debian/zig/usr/bin/zig build test-behavior || exit 1;
./debian/zig/usr/bin/zig build test-compiler-rt || exit 1; ./debian/zig/usr/bin/zig build test-minilibc || exit 1;
./debian/zig/usr/bin/zig build test-compare-output || exit 1; ./debian/zig/usr/bin/zig build test-standalone || exit 1;
./debian/zig/usr/bin/zig build test-stack-traces || exit 1; ./debian/zig/usr/bin/zig build test-cli || exit 1;
./debian/zig/usr/bin/zig build test-asm-link || exit 1; ./debian/zig/usr/bin/zig build test-runtime-safety || exit 1;
./debian/zig/usr/bin/zig build test-translate-c || exit 1; ./debian/zig/usr/bin/zig build test-run-translated-c || exit
1; ./debian/zig/usr/bin/zig build test-std || exit 1;
/bin/sh: 1: ./debian/zig/usr/bin/zig: not found
make[1]: *** [debian/rules:16: override_dh_auto_test] Error 1
make[1]: Leaving directory '/home/bage/zig-0.9.1'
make: *** [debian/rules:8: binary] Error 2
d/watch
=======
The watch file in your upload differs from the one in git. Please keep them in sync.
d/changelog
===========
As long as the package is not sponsored, please only keep one version (0.9.1-1) with the ITP closing entry. Your latest
upload has 3 versions.
d/copyright
===========
Please use more wildcards so you do not have to list so many files.
Your comment:
"COPYRIGHT file has a lont list of "Authors/contributors include". Should these be added here in some way?"
You should first think if the whole musl dir can be replaced with the musl-dev package.
If so, you can repack the tarball, else you stick to the Copyright line, as required by the Expat license.
The long list of authors does not claim they are copyright holders but "Authors/contributors".
The repackaging comment does not only go for musl but also the other 3rd party components.
BSD-4-clause is not correctly represented. You replaced the 3rd clause's acknowlegement with "This product includes
software developed by this project." However, this mentions the University of California in the referencing files.
For BSD-4-clause by UC California specifically you can just remove the whole 3rd clause because the Regents allowed to
do so once upon a time. If there is a file with different acknowlegement please keep it as-is.
CC0 is in Debian's common-licenses. Please replace the whole text with a reference like in the GPL variants.
BSD-2-clause-NetBSD is not the right license. You copied the ISC from lib/libc/mingw/misc/getopt.c, not the
BSD-2-clause-NetBSD.
There is more to come; I have only reviewed the overall appearance of the file.
What is the debian.decopy file about?
d/patches
==============
Please do not include if you do not have at least one patch.
Reply to: