[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1025959: Feedback regarding RFS: davmail/6.0.1.3390-2



On Wed, Dec 14, 2022 at 10:14:09AM +0100, Alexandre Rossi wrote:
> Hi,
> 
> >  * Add the release "davmail (6.0.1.3390-1.1)" to packaging git repo
> 
> Pushed.

Ack

> Further changes are awaiting upload to unstable before being pushed.

See below
 
> >  * Review / improve the  `prepare-service`
> 
> This history behind this script is detailed in:
> 
> startup script that copies keystoreFile to StateDirectory (Closes: #968236)
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968236

Seen the "adduser  _davmail" advice.
And seeing that "adduser _davmail" in  debian/davmail-server.postinst
(I didn't see that post install script yesterday)
 
> The point is to make available private keys to the daemon. Do you think I need
> to add comments to the script to explain the purpose?

Yes please, elaborate purpose  AND  elaborate the

    if keystore is a file then create keystore file

 
> >  * Make that `davmail-service` makes it into `davmail-server` package
> 
> Fixed, thanks and sorry for that.

Thanks for fixing and thanks for confirming the "good catch".

 
> >  * Ping me
> 
> New source package is on mentors.

What about doing this development in a git branch?

Your benefit:  No need for a `dput` to mentors, just `git push` the
               branch.

My benefit: No need to visit mentors for URL that I can `dget`,
            just `git pull`.

Another benefit for you: No duplicates in reporting progress.
                         Report to "git" by commit message. 

Tell me the branch name to use.
Telling me there won't be such development branch is fine, we use mentors.


> Alexandre

Groeten
Geert Stappers
Fully aware that the freeze before the Bookworm release is nearby
-- 
Silence is hard to parse


Reply to: