Bug#1025871: RFS: d11amp/0.59-1 [ITP] -- Simple MP3 player (All green now)

[Thomas Dettbarn <dettus@dettus.net>]

On 12/11/22 15:44, Adam Borowski wrote:
> On Sat, Dec 10, 2022 at 11:32:04PM +0100, Thomas Dettbarn wrote:
> > The package is ready, and you can use it to have your
> > very own retro MP3 player on your desktop. It has the
> > big advantage that the license situation is 100% clear.
> While, as Bastian mentioned, we have plenty of MP3 players in the archive
> already, I don't believe that's a reason to block someone from working on
> something they consider to be worth spending their time on -- as long as
> there's no significant cost to the project.
>
> A random package like this costs us ~1KB increase of Packages index
> downloads, minor cycles during archive rebuilds, and basically that's it.
>
> >   * Package name     : d11amp
> >     Version          : 0.59-1
> >     Upstream contact : Thomas Dettbarn<dettus@dettus.net>
> >   * URL              :https://www.dettus.net/d11amp/
> >   * License          : BSD-2-Clause
> >   * Vcs              :https://github.com/dettus/d11amp/
> > The source builds the following binary packages:
> >    d11amp - Simple MP3 player
> Alas, the package fails for me:
> /bin/sh: 1: pkg-config: not found     [eleventy times]
> src/audiooutput/audiooutput_portaudio.c:28:10: fatal error: portaudio.h: No such file or directory
>     28 | #include <portaudio.h>
>        |          ^~~~~~~~~~~~~
> src/decoder/decoder.c:26:10: fatal error: gtk/gtk.h: No such file or directory
>     26 | #include <gtk/gtk.h>
>        |          ^~~~~~~~~~~
> In file included from src/gui/theme_manager.c:33:
> src/gui/theme_manager.h:30:10: fatal error: gdk-pixbuf/gdk-pixbuf.h: No such file or directory
>     30 | #include <gdk-pixbuf/gdk-pixbuf.h>
>        |          ^~~~~~~~~~~~~~~~~~~~~~~~~
> ... and so on.  Full log attached.
>
>
> I see, your Build-Depends list binary libraries rather than headers:
> Build-Depends: debhelper (>=11),
>                 debhelper-compat (= 13),
>                 libc6 (>= 2.34),
>                 libcairo2 (>= 1.2.4),
>                 libgdk-pixbuf-2.0-0 (>= 2.22.0),
>                 libglib2.0-0 (>= 2.31.8),
>                 libgtk-4-1 (>= 4.0.0),
>                 libmpg123-0 (>= 1.28.0),
>                 libportaudio2 (>= 19+svn20101113),
>                 libzip4 (>= 0.10)
> What you need is to replace the runtimes with devel packages:
>      libgtk-4-dev
>      libzip-dev
> and so on.
>
> There's no need to list libc6/libc-dev (it's in build-essential), the
> bdependency on debhelper is redundant (you already pull debhelper-compat),
> and as shown by the "pkg-config: not found" you need pkgconf (which is
> the new implementation of pkg-config that replaced it).
>
>
> Meow!

Hello Adam.

Thank you so much! My previous package did not have any dependencies, I 
am still learning. :)

So, I stripped down the Build-Depends slightly, they now look like this:

Build-Depends: debhelper-compat (= 13),
               libgdk-pixbuf-2.0-dev (>= 2.22.0),
               libgtk-4-dev (>= 4.0.0),
               libmpg123-dev (>= 1.28.0),
               libzip-dev (>= 0.10),
               portaudio19-dev,
               pkgconf

What do you think?  Upload #9 on mentors.debian.net looks okay to me.


Purrrrr.

PS: As for the "too-many-mp3-players" argument... I think it is great 
for the user to have one more
alternative. To me, this is what Open Source is all about: Not having 
one software vendor, telling
me which software I have to use; but several, to choose from. And to 
decide what works best
for me, or to become another software vendor myself. :)