Bug#1022168: Review
Control: tags -1 moreinfo
Hi Robin,
Here is my review of this package:
* Remove debian/patches directory - you do not have any patches to apply
* debian/changelog: Remove all changelog entries and just have 1 with
Initial packaging, closing the ITP bug. This is the first time this
package has been uploaded to Debian, so there are no changes to report.
* debian/control: Standards version can drop the .1 at the end - just
need to track up to the patch version. Also update to 4.6.1
* debian/rules: DEB_CFLAGS_MAINT_APPEND has a double space after it
* debian/copyright:
- m4/ax_check_compile_flag.m4 - this licence text is not listed in
d/copyright. The file is listed, but the licence text in the file does
not match the licence text in d/copyright
- The comment should be removed (xml and html files)
There is currently a false-positive lintian error that should be added
to debian/source/lintian-overrides:
E: odr-audioenc source: source-is-missing [libtoolame-dab/html/psycho.html] │
Cheers
Kyle
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze
Reply to: