Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors
On Fri, Nov 18, 2022 at 01:18:05PM -0500, Antoine Beaupré wrote:
> It looks like it ships a third-party library, nanosvg. I don't know if
> that's already packaged in Debian, but it might make the FTP-masters
> unhappy, especially since it's not mentioned in debian/copyright. So the
> latter should be fixed, at the very least, and we might consider
> packaging that library separately...
>
> ... that said, it looks like many other packages do ship a copy of that
> library, maybe it's the way it's designed to be shipped?
>
> https://codesearch.debian.net/search?q=nanosvg&perpkg=1
>
> wxwidgets just vendors it, but does mention it in the debian/copyright,
> however:
>
> https://sources.debian.org/src/wxwidgets3.2/3.2.1%2Bdfsg-1/debian/copyright/#L28
>
> So there's that: at least add that to the debian/copyright.
Thanks for your patch! I posted a note regarding nanosvg:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982140#12
> Also, I've had trouble reproducing the upstream tarball. I tried to
> build the package with git-buildpackage:
>
> gbp buildpackage --git-debian-branch=main --git-upstream-tag=1.8.2
>
> ... but that gives me a different tarball than
> upstream. git-buildpackage generates a tarball with foot-1.8.2/ as a
> top directory, while upstream has foot/. I'm not sure how to resolve
> this, but you should at least provide the upstream tarball ... somewhere
> so that it can be uploaded safely.
>
> You might want to configure git-buildpackage or some other git-building
> tool in the package as well, since it seems that (git) is what you rely
> on to build this.
I checked UPSTREAM TARBALL CREATION OPTIONS in gbp-buildpackage(1) for
an option to set the prefix that could be used in gbp.conf, but could
not find anything. The default might have been chosen to match GitHub.
I use debuild with lintian in buildah to build Debian packages:
https://www.debian.org/doc/manuals/maint-guide/build.en.html#debuild
https://tauware.blogspot.com/2020/04/building-packages-with-buildah-in-debian.html
> I can probably just live with the upstream tarball for now, but that
> might be something you want to consider documenting in
> debian/README.source or something.
I have documented to obtain the tarball with origtargz:
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/777f02bbb38f229016bb41fc90ebfc923da46e98
# sha256sum ../fuzzel_1.8.2.orig.tar.gz
2e7debba9d56a989921e0ce518a026152d9fbea33abafe384a4aad074db89de8 ../fuzzel_1.8.2.orig.tar.gz
> Otherwise this is almost ready to go, as far as I'm concerned, and I'll
> be happy to sponsor this once it has a proper debian/copyright. Try
> running decopy on the source to see what comes up...
Thanks for your review! This is latest commit of the package:
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/ccc1a63f6289c33560f0ff85a5143e0e47daa529
Regards,
Peter
Reply to: