[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#1008882: RFS: odr-audioenc/3.2.0-1 [ITP] -- DAB and DAB+ encoder that integrates into the ODR-mmbTools



Thank you very much Paul.

I will apply all your esuggestions with one exception though: the section will be non-free/hamradio in the end, for I made a mistake when I wrote the initial email (my apologies).

I should have written instead that the upstream odr-audioenc *INCLUDES MODIFIED SOURCES* of fdk-aac (Fraunhofer FDK AAC Codec Library for Android). Since the original version of the Fraunhofer FDK AAC Codec Library for Android (I believe it is libfdk-aac-dev) is non-free, I guess that the modified sources also belong to non-free and thus odr-audioenc becomes non-free as well.

On 20.10.22 10:09, Paul Wise wrote:
On Wed, 2022-10-19 at 10:26 +0200, Robin Alexander wrote:

My package odr-audioenc was rejected after it reached the NEW queue
because one of the library it depends on does not belong to "main" but
to "non-free". I therefore need to change the section in file
debian/control from "hamradio" to "non-free/hamradio" and submit the
package again.
If the package itself is otherwise free, you want contrib not non-free.
The library will go to non-free of course though.

- Do I need to change the package release from 1 to 2 because of this
debian/control file change or can I keep the same package release, given
that the package never made it to unstable
I'm not sure, but I think it would be best to change it, as
documentation of the changes done based on ftp-master feedback.

- Can I take the opportunity of this change to include the latest
upstream version?
Yes.

can I delete the repository on salsa and re-create it again before
pushing the package?
Yes, the git repo isn't very relevant here.

--
Robin ALEXANDER


Reply to: