Bug#1015169: RE: Bug#1015169: RFS: mir-eval/0.7-1 [ITP] -- Common metrics for common audio/music processing tasks
- To: 1015169-submitter@bugs.debian.org
- Subject: Bug#1015169: RE: Bug#1015169: RFS: mir-eval/0.7-1 [ITP] -- Common metrics for common audio/music processing tasks
- From: Bastian Germann <bage@debian.org>
- Date: Thu, 1 Sep 2022 15:16:23 +0200
- Message-id: <[🔎] da0b83aa-7f33-77cf-1dc6-50f1fce76e79@debian.org>
- Reply-to: Bastian Germann <bage@debian.org>, 1015169-quiet@bugs.debian.org
- In-reply-to: <CPZP284MB0696DC6C8D1722E75BB06BCDD19B9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM>
- References: <CPZP284MB0696005BC86B184D4FE17302D18A9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <CPZP284MB0696005BC86B184D4FE17302D18A9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <CPZP284MB0696005BC86B184D4FE17302D18A9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <dfa6bde3-335a-4621-f388-11a03ef720dd@debian.org> <CPZP284MB0696BEF7BF6931699C82E843D1919@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <287ae837-b027-43d9-754e-5b67b212f9b8@debian.org> <CPZP284MB0696FB679A782D9E49ED55C8D1909@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <a0fe98f3-9df7-d487-6802-2e52ce375dc2@debian.org> <CPZP284MB06965796F1E02A1B3D28018AD1909@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <CPZP284MB0696DC6C8D1722E75BB06BCDD19B9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <CPZP284MB0696DC6C8D1722E75BB06BCDD19B9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM> <CPZP284MB0696005BC86B184D4FE17302D18A9@CPZP284MB0696.BRAP284.PROD.OUTLOOK.COM>
Control: tags -1 moreinfo
The 700+ line patch is not acceptable as-is. A general note for patches: Please do not comment out but really remove
lines that you do not want because commenting results in two patch lines (- and +), which makes it very hard to review a
patch and get the idea of it.
When I run the tests without your patch, I can see
ERROR: test_input_output.test_load_tempo
----------------------------------------------------------------------
Traceback (most recent call last):
...
FileNotFoundError: [Errno 2] No such file or directory: 'data/tempo/ref01.lab'
======================================================================
ERROR: test_input_output.test_load_tempo_multiline
----------------------------------------------------------------------
...
FileNotFoundError: [Errno 2] No such file or directory: 'data/tempo/bad00.lab'
======================================================================
ERROR: test_input_output.test_load_tempo_badweight
----------------------------------------------------------------------
...
FileNotFoundError: [Errno 2] No such file or directory: 'data/tempo/bad01.lab'
======================================================================
ERROR: test_input_output.test_load_bad_tempi
----------------------------------------------------------------------
...
FileNotFoundError: [Errno 2] No such file or directory: 'data/tempo/bad02.lab'
I think, you can get these tests to run by running the tests with the current working directory set to tests/ in the
source dir instead of .pybuild/cpython3_3.10_mir-eval/build.
If you cannot get pybuild to change to that dir please use override_dh_auto_test.
In https://github.com/craffel/mir_eval/issues/350, upstream also suggests that the tests should run generally.
The only tests that I expect to fail are the ones which use that old matplotlib feature.
Changing the directory will maybe also fix:
test_melody.test_to_cent_voicing
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/bage/mir-eval/.pybuild/cpython3_3.10_mir-eval/build/tests/test_melody.py", line 118, in test_to_cent_voicing
ref_file = sorted(glob.glob(REF_GLOB))[0]
IndexError: list index out of range
which is the trigger for many other failing tests.
Reply to: