[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1014078: RE: Bug#1014078: RFS: librosa/0.9.2-1 [ITP] -- Python package for music and audio analysis



Am 21.10.22 um 16:58 schrieb Nilson Silva:
https://salsa.debian.org/nilsonfsilva/librosa/-/pipelines/442787

Looks like you are running the tests from the wrong directory again, like in some other of your packages that I have reviewed.

Your tests were in another repository outside the pact: https://github.com/librosa/librosa/tree/main/tests

I do not understand what you mean by this.

Instead of doing a commit through dpkg, which would be too big, I included the test files inside librosa in the package. In my cow build cage the sbuild is building the .deb but in the parsley is not passing.

What is a parsley? Do you mean the salsa CI runner?
I see that you have added massive testfiles.
Are you aware that they need to have a DFSG-free license?
(I did not check their licenses.)

In general, it would help very much to have the changes to the debian/ directory in logically separated git commits to see what you did with the package. This will speed up the review process very much.


Reply to: