Bug#1002295: Uploaded the files
On Tue, Aug 02, 2022 at 08:12:11PM +0000, Scorpion2185 wrote:
> Hi Tobias,
>
> Thanks for your review.
>
> - the watch file is still broken [1]
> - upstream seems not to do releases, where did you get the 0.2.0 version
>
> I asked upstream about the release number.
> And on the github page you can see: "Initial version is 0.2.0".
> If you click the 3 dots near "pippim Create mt".
>
> I will ask to add tags so that versioning and watch file will work better.
>
> - Consider sending your patches upstream.
>
> I told upstream about the files that I made but they made the app for Ubuntu and don't care for making it work well on various DEs.
> And they don't care about the .desktop and other things e.g. the man page that complete the app.
That's a pitty, as this would help other people / distirubtions as well…
(I'd doinrg PRs on github so that those other peoples have a way to get them)
Said that, if upstream is not intrested in working with distributions, this
might be a sign that their software possibly is not a good match to be included
in distribution or Debian… At least this raised a flag to considere _if_ this
should be really in Debian…
Please talk about this with your upstream, we do not want to agonize them
but it also not ideal to become a de-facto fork, if we find out later that have
to carry a ton of local modifications…
> - "mt" is proably not a good choice for the script name
>
> I will ask.
>
> - d/alarm_001.wav
>
> I don't think that providing a timer without its own alarm is good.
Upstream is using
/usr/share/sounds/freedesktop/stereo/alarm-clock-elapsed.oga
which is in the package sound-theme-freedesktop.
I think there is no reason to divert from upstream here.
> - d/README
(I did not check updates to this file, my reply is based on this mail alone)
> - users are not supposed to change binaries shipped by a package.
>
> I think that it is best to give an option to how do something since there is no such feature, than nothing.
do not recommend bad practices. This is not appropiate for a package.
> - IIUIC, the section "Interface to Sysmonitor Indicator Option"
> tells people to create a FrankenDebian [3]
>
> I made it to explain why the option doesn't work.
Don't recommend creating a FrankenDebian or point people to PPAs.
> - d/control
> - Why does it need a versioned dependency on bash?
> - bash is essential, and the version >4.6 is already fullfilled in old-stable.
>
> Without the version I get an error or warning on https://mentors.debian.net/package/multi-timer/.
You do not need to Depend: on Essential packages, they are always installed. (Policy 3.8 has details)
> ------- Original Message -------
> On Monday, August 1st, 2022 at 6:39 PM, Tobias Frost <tobi@debian.org> wrote:
>
>
> > Control: tags -1 moreinfo
> >
> > Hi Scorpion,
> >
> > I wonder if you actually checking things, with the hints given by Bastian
Reply to: