Hi Luca, On Wed, Jul 27, 2022 at 12:38:07PM +0100, Luca Boccassi wrote: > > Dear mentors, > > > > I am looking for a sponsor for my package "archlinux-keyring": > > I can sponsor this. > > A few comments on the package: > > - I imagine the makefile patch will be upstreamed? > - no need to repeat the GPL3 license snippet in debian/copyright, have > it as a single line in the Copyright stanzas: "License: GPL-3+", and > then one block at the bottom of the file with "License: GPL-3+" and the > full body to follow. > - the keyring files are installed in /usr/share/pacman/keyrings/ but > other keyrings (like ubuntu-keyring) install to /usr/share/keyrings, so > I think this should do the same for consistency > - in debian/control the VCS fields list > https://gitlab.archlinux.org/archlinux/archlinux-keyring as the > repository, but there's no sign of the packaging code there. You should > have it on a debian/sid (or similar) branch. > Thanks for the review! I've addressed the feedback, and also bumped to the newly released 20220727 https://mentors.debian.net/package/archlinux-keyring/ https://salsa.debian.org/michel/archlinux-keyring/-/tree/main Note: after deduplicating the GPL-3+ snippets, this now generates an additional lintian warning because it thinks the license snippet is missing. Best regards, -- Michel Alexandre Salim identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
Attachment:
signature.asc
Description: PGP signature