Bug#1014117: RFS: edgar/1.35-1 [ITA] -- Legend of Edgar platform game
On Thu, 2022-06-30 at 17:10 +0200, Bastian Germann wrote:
> Am 30.06.22 um 17:00 schrieb Matt Barry:
> > I'm willing to
> > wade through it, but is the position of the project immovably that
> > eg.
> > ogg files are not redistributable without "source"? (Are there
> > examples of packages that actually do this?)
>
> Please see an example with Photoshop files for pngs at
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1010399#25
> If source files exist they have to be provided. If the ogg files are
> the primary form of modification it is okay in my
> opinion. You have to do a little research for that. I have not even
> checked if the files are still existing with the new
> version.
Thanks for the reference; I will do some reading.
>
> The git repo that you have used to build the new version was actually
> not used by the former maintainer who got the
> pkg into Debian. The version in the archive is completely different.
> The git repo should be rebuilt using gbp
> import-dscs --debsnap. I can do that for you if you do not know how
> to. The archive also holds a seemingly complete
> copyright file, which your version lacks.
That makes sense; let me see if I can figure it out.
>
> Also, please separate your debian/ changes from the upstream changes.
> That is what master and upstream branches are for.
To clarify, I think that I rebased the upstream merge and debian/
changes into a single commit, which should be separate? (That makes
sense to me, just making sure.)
Thanks!
Matt
Reply to: