[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1010242: RFS: opengnb/1.2.8.7-1 [ITP] -- via P2P to setup de-centralized layer3 network VPN



Am 26.05.22 um 06:05 schrieb xiao sheng wen(肖盛文):
Files: libs/protocol/network_protocol.h
Copyright:1995, 1996, 1997, and 1998 WIDE Project.
           1982, 1986, 1993 The Regents of the University of California.
License: BSD-3-clause
Comment: The upstream distribution does not contain an explicit statement of
  copyright ownership.
  .
  struct ip6_hdr come from FreeBSD: src/sys/netinet/ip6.h
  /*      $FreeBSD: src/sys/netinet/ip6.h,v 1.5 2001/06/11 12:39:00 ume
Exp $ */
  /*      $KAME: ip6.h,v 1.18 2001/03/29 05:34:30 itojun Exp $    */
  .
  struct iphdr come from BSD, modified by upstream author.
  The other parts of this file is write by upstream author.

Is this acceptable?

Please change the last comment to say:
struct iphdr comes from FreeBSD and is modified by the upstream author.
The other parts of this file is written by the upstream author.

Otherwise this looks good.

ed25519's license name "Expat" is misleading. Please rename it to "zlib".

For murmurhash, you would have to find the original version to really know
that it is public-domain. The nginx version has a copyright statement but I
could find murmurhash v2 implementations that are public domain. However, I
did not find the nginx version elsewhere quickly.
Your comment "It is assumed that all content is copyright by its respective
authors unless otherwise stated" actually contradicts the idea of public domain,
which to get rid of copyright explicitly for some copyrightable work.

If you do not find the original, please consider replacing this file.
There is at least the package libmurmurhash available (but I do not know if it is
an equivalent version).

I also minor update the d/control file for the package description's
grammar.

Here is my suggestion:

Description: P2P de-centralized layer 3 VPN
 OpenGNB is a de-centralized virtual private network (VPN) to set-up a
 layer 3 network via P2P with the capability of NAT traversal.
 .
 OpenGNB can add many nodes and LANs together into one big VPN.
 OpenGNB supports public index nodes to forward net packages.
 .
 opengnb support the following platforms:
 Linux, FreeBSD, OpenBSD, and macOS.
 .
 OpenGNB uses UDP by default. With the software gnb_udp_over_tcp
 installed it can also use TCP.


Reply to: