On Mon, 2022-05-09 at 20:18 -0700, Michel Alexandre Salim wrote:
> I am looking for a sponsor for my package "psi-notify":
I prefer that three issues are fixed before uploading psi-notify:
Since the package requires Linux kernel PSI APIs, it probably won't
work on kFreeBSD or Hurd, if so, change Architecture to linux-any.
Please s/MIT/Expat in debian/copyright, see here for details of why:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name
Presumably the debian/ directory is not copyright by upstream,
so please add a second stanza like this:
Files: *
Copyright: 2020-present Christopher Down
License: Expat
Files: debian/*
Copyright: 2022 Michel Alexandre Salim
License: Expat
License: Expat
...
These issues would be nice to fix at some point:
The Depends on libnotify-bin doesn't appear to be needed, since
no part of the package uses notify-send as far as I can tell,
since it seems that psi-notify uses libnotify instead.
You don't need the Closes in the second changelog entry, since when
building the package for upload to NEW, dpkg-buildpackage -v0 should be
used when there are multiple changelog entries, so that all of the
changelog entries are present in the .changes file and all of the bugs
closed by all of the entries are added to Closes in the .changes file.
Alternatively you can collapse all the entries into one, your choice.
Enable the additional hardening options, unless they break something.
Drop or uncomment all the commented out things from debian/rules.
Drop override_dh_install since you have debian/install.
I prefer to wrap the files in the debian/ dir using this:
wrap-and-sort --short-indent --wrap-always --sort-binary-packages --trailing-comma
Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata
Please think about how to add autopkgtests at some point.
https://ci.debian.net/doc/
The upstream README.md references galago-project.org, which is dead.
The notification spec has moved here, please send a patch upstream:
https://specifications.freedesktop.org/notification-spec/latest/
You might like to send upstream a patch adding install to the Makefile
which would make debian/install obsolete. You can find inspiration for
this in the Makefile of mpv-mpris. It allows installing as a user or as
root, allows overriding the user/root detection, uses the right prefix,
supports DESTDIR etc. Note that for installing the systemd unit file,
you should look up the right paths using pkg-config.
Once the package has been accepted into Debian, please send upstream a
patch linking to the Debian package. Alternatively, just replace that
section of the README.md with a link and or badge for Repology:
https://repology.org/project/psi-notify/versions
I'm not sure how demo.gif was created, but I'm assuming it was manually
recorded, which means it can get out of sync with the code, it would be
nice if upstream would create it dynamically at build time.
These complaints from the lintian tool could be fixed:
$ lintian --info --display-info --display-experimental --pedantic --show-overrides --color auto
I: psi-notify source: debian-watch-contains-dh_make-template <project> [debian/watch]
I: psi-notify: hardening-no-bindnow [usr/bin/psi-notify]
I: psi-notify: hardening-no-fortify-functions [usr/bin/psi-notify]
X: psi-notify source: upstream-metadata-file-is-missing
When I run check-all-the-things, these tools report things that
potentially could be fixed: cme check dpkg, cppcheck, flawfinder,
grep http:, iwyu, PATH_MAX, proselint, wrap-and-sort, yamllint.
Some of them are about Debian things, some are upstream things.
https://github.com/collab-qa/check-all-the-things
--
bye,
pabs
https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part