[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#994564: RFS: sosreport/4.2-1 -- Set of tools to gather troubleshooting data from a system



* [sos.conf]
The right configuration location is in '/etc/sos' and the package contains it. 
I'll look at why and how the package ends up having '/usr/config/sos.conf' too:

# dpkg -l sosreport
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=========================================================
ii  sosreport      4.2-1        amd64        Set of tools to gather troubleshooting data from a system

# dpkg -L sosreport | grep -i sos.conf
/etc/sos/sos.conf -> Well placed
/usr/config/sos.conf -> Misplaced
/usr/share/man/man5/sos.conf.5.gz

* [manpages mangled]

I looked most man pages:
man sos-report
man sos-collect
man sos-mask
....

I couldn't find anything mangled. Do you have an example I can refer too ?

[builtin modules]
I'll look into it and see what can be done.

[Running services]
"it fails to list running services, and probably many more" 
Are you referring to 'path_to_sosreport/ps' collection ? Or other services ? 
[systemd/rc-agnostic]
sos project main focus is on systemd. Most of the other 'init' type as been removed (upstart, ...): 297011da [upstart] Remove plugin


On Sun, Sep 19, 2021 at 5:22 AM Adam Borowski <kilobyte@angband.pl> wrote:
On Fri, Sep 17, 2021 at 02:53:36PM -0400, Eric Desrochers wrote:
>  * Package name    : sosreport
>    Version         : 4.2-1

>  sosreport (4.2-1) unstable; urgency=medium
>  .
>    * New 4.2 upstream release.
>      - This release contains numerous improvements
>        and bug fixes to several components within sos,
>        including an overhaul to the project's test suite
>        and infrastructure.
>  .
>    * For more details, full release note is available here:
>      - https://github.com/sosreport/sos/releases/tag/4.2
>  .
>    * Former patches, now fixed:
>      - d/p/0002-fix-dict-order-py38-incompatibility.patch
>      - d/p/0003-systemd-prefer-resolvectl-over-systemd-resolve.patch
>  .
>    * Remaining patches:
>      - d/p/0001-debian-change-tmp-dir-location.patch

Hi!
There's an obviously misplaced file: /usr/config/sos.conf

The man pages are mangled, at least their headers.

Upstreamish issues:
* when run, it spams about missing kernel modules despites them being
  built-in.  It _tries_ to detect them, but by looking into a bogus
  path (/usr/lib/modules/%s/modules.builtin -- it's in /lib/); it should
  check /sys/module/ instead of assuming the running kernel is available
  on the disk.
* it fails to list running services, and probably many more.  I see it
  hard-codes systemd specific commands instead of rc-agnostic ones.

And upstreamish but really should be patched: the "Debian" module knows
only about wheezy and jessie...


Meow!
--
⢀⣴⠾⠻⢶⣦⠀ < thunder> perhaps we can just call rude people "attitudinally
⣾⠁⢠⠒⠀⣿⡁            challenged", designate them as disabled, and then
⢿⡄⠘⠷⠚⠋⠀            object to any criticism towards them on the basis
⠈⠳⣄⠀⠀⠀⠀            that it would violate the CoC...

Reply to: