[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#993499: RFS: python-marshmallow-polyfield/5.10-1 -- marshmallow extension for polymorphic fields



Control: tags -1 - moreinfo

Hello Jeroen,

and thanks for the review!

> copyright: where does the 2015 upstream copyright year come from?

I think it was added during the initial packaging based on the year of
the first upstream public release, but indeed there is no explicit
mention of 2015 in the upstream sources. I have added a comment to
d/copyright, but I'm not sure if this is the best approach - any
guidance would be welcome.

> control:
>   * why hardcode the dependency on python3-marshmallow for the binary pkg?

Unintentional - and fixed.

>   * the build-dep on the same also seems unneeded (at least unless/until
>     tests are re-enabled, see watch)
> 
> watch: consider using github for upstream releases, as the files
> published there include the upstream testsuite missing on pypi. And then
> put those tests to good use, of course :)

Switched to using github releases, re-enabling the tests during build
and also adding autopkgtests.


Thanks,
-- 
Diego M. Rodriguez


Reply to: