Bug#993552: RFS: proton-caller/2.3.2-1 [ITP] -- Run any Windows program through Proton
Hi!
On Thu, Sep 02, 2021 at 09:38:00PM -0400, Ben Westover wrote:
> * Package name : proton-caller
> Version : 2.3.2
> * URL : https://github.com/caverym/proton-caller/
> * License : GPL-3+
^^^^^^^^^^^^^^^^^^^^^^^^
The license is MIT. Please correct debian/copyright.
> Description : Run any Windows program through Proton
> dget -x https://mentors.debian.net/debian/pool/main/p/proton-caller/proton-caller_2.3.2-1.dsc
The program depends on non-free Steam, thus it can't go into the main
archive. It is a nice specimen of a "contrib" package, though.
You can put it there by changing Section to contrib/XXX.
The package fails to build:
.----
cargo build --release --locked
make: cargo: No such file or directory
`----
Fix: Build-Depends: cargo
For a new package, there should be only one changelog entry (unless the
package already exists in a repository used by actual other people).
The long descriptions really should be longer than one line. It'd be nice
if you could write something more what is it good for (as I understand,
it's an equivalent to "wine freecell.exe"), what's the diff from Wine, etc.
An upload to Debian must be targetted at "unstable" or "experimental"
(other options being irrelevant for now), you currently have it set to
"UNRELEASED".
debian/rules is missing a lot of functionality: mandatory targets like
{build,binary}-arch; passing build flags, handling cross builds, etc.
All of this would be much better done with dh (like the vast majority
of packages in Debian do) -- it does know how to use cargo, etc.
Likewise, there's no need to run install by hand.
*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*&*
I won't continue the review -- I'll leave sponsoring this package to
someone with adequate knowledge of rust/cargo, which I lack.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ If you ponder doing what Jesus did, remember than flipping tables
⢿⡄⠘⠷⠚⠋⠀ and chasing people with a whip is a prime choice.
⠈⠳⣄⠀⠀⠀⠀
Reply to: