[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#990722: RFS: cool-retro-term/1.1.1+git20210605-1 -- terminal emulator which mimics old screens



Control: tags -1 moreinfo

Hi Gürkan,

Regarding cool-retro-term:

- I see in "README.source": 

> repackaged to include qmltermwidget
> 
> dropped these fonts
> app/qml/fonts/modern-monaco: not distributable (Apple)
> (...)

But I do not see a +dfsg nor a Files-Excluded in d/copyright to automatically
repack.  (this bug is already present in past uploads; will file a bug)

- It is not the proper to include qmltermwidget. it should be packaged
separately.  (this bug is already present in past uploads; will file a bug)

- d/copyright is buggy.  (this bug is already present in past uploads; will file
a RC bug)
	- qmltermwidget seems to be partly GPL-2+ and LPGL-2+; both not
documented. There is at least one cmake files that seems to be BSD

- the patches only have boilerplate dep3 headers and therefore their intentions
is nor really obvious.

- Watch file is not working. If you package git snapshots, it needs also
be able to pick those up.  (this bug is already present in past uploads; will
file a bug)

- I could not match the upstream version to the version being sponsored.
The version string in d/changelog indicates it is git version from
June 05th, 2021 however, there is no commit on that date upstream; the
last one before that date is March 25th [1]. However, the downloaded
zip content does not match this debian source package.

This is a show stopper.

[1]
https://github.com/Swordfish90/cool-retro-term/tree/39181f42cf859952b1d880879791ef5a9b7adad0
>  

- Is this upload suppose to fix #988502? (as you point to the RFS in that bug)


- Lintian (I'm not sure whether they have merit, though; /me not an font
expert.)

W: cool-retro-term source: absolute-symbolic-link-target-in-source
app/qml/fonts/1971-ibm-3278/3270-Regular.ttf ->
/usr/share/fonts/opentype/3270/3270-Regular.otf
W: cool-retro-term source: absolute-symbolic-link-target-in-source
app/qml/fonts/1979-atari-400-800/AtariClassic-Regular.ttf ->
/usr/share/fonts/truetype/fonts-atarismall/AtariSmall.ttf
W: cool-retro-term source: absolute-symbolic-link-target-in-source
app/qml/fonts/1981-ibm-pc/PxPlus_IBM_BIOS.ttf ->
/usr/share/fonts/pc/Px_IBM_BIOS.ttf
W: cool-retro-term source: absolute-symbolic-link-target-in-source
app/qml/fonts/1985-ibm-pc-vga/PxPlus_IBM_VGA8.ttf ->
/usr/share/fonts/pc/Px_IBM_VGA8.ttf
W: cool-retro-term source: absolute-symbolic-link-target-in-source
app/qml/fonts/modern-inconsolata/Inconsolata.otf ->
/usr/share/fonts/truetype/inconsolata/Inconsolata.otf

(I did not find those symlinks in the upstream repo)

W: cool-retro-term source: inconsistent-appstream-metadata-license
packaging/appdata/cool-retro-term.appdata.xml (mit != gpl-3)
W: fonts-hermit: opentype-font-prohibits-installable-embedding [edit only]
usr/share/fonts/truetype/hermit/Hermit-bold.otf
W: fonts-hermit: opentype-font-prohibits-installable-embedding [edit only]
usr/share/fonts/truetype/hermit/Hermit-light.otf
W: fonts-hermit: opentype-font-prohibits-installable-embedding [edit only]
usr/share/fonts/truetype/hermit/Hermit-medium.otf
I: qml-module-qmltermwidget: package-contains-documentation-outside-usr-share-
doc usr/lib/x86_64-linux-gnu/qt5/qml/QMLTermWidget/kb-layouts/README
I: cool-retro-term source: patch-not-forwarded-upstream debian/patches/drop-non-
free-fonts
I: cool-retro-term source: quilt-patch-using-template-description drop-non-free-
fonts
I: cool-retro-term source: quilt-patch-using-template-description strip-non-
free-fonts
I: cool-retro-term: spelling-error-in-binary usr/bin/cool-retro-term NAm Name
X: cool-retro-term source: debian-watch-does-not-check-gpg-signature
P: cool-retro-term source: maintainer-manual-page debian/cool-retro-term.1



On Mon, 05 Jul 2021 17:45:35 +0200 =?UTF-8?Q?G=C3=BCrkan_Myczko?=
<gurkan@phys.ethz.ch> wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "cool-retro-term":
> 
>   * Package name    : cool-retro-term
>     Version         : 1.1.1+git20210605-1
>     Upstream Author : Filippo Scognamiglio <flscogna@gmail.com>
>   * URL             : https://github.com/Swordfish90/cool-retro-term
>   * License         : OFL-1.1, dfsg-compliant-text, BSD-3-clause, MIT, 
> GPL-3
>   * Vcs             : 
> https://salsa.debian.org/myczko-guest/cool-retro-term
>     Section         : x11
> 
> It builds those binary packages:
> 
>    fonts-proggy - Monospaced bitmap programming font
>    fonts-terminus - Terminus monospace font
>    fonts-hermit - Monospace Hermit Font for programming
>    qml-module-qmltermwidget - QML port of qtermwidget
>    cool-retro-term - terminal emulator which mimics old screens
> 
> To access further information about this package, please visit the 
> following URL:
> 
>    https://mentors.debian.net/package/cool-retro-term/
> 
> Alternatively, one can download the package with dget using this 
> command:
> 
>    dget -x 
>
https://mentors.debian.net/debian/pool/main/c/cool-retro-term/cool-retro-term_1.1.1+git20210605-1.dsc
> 
> Changes since the last upload:
> 
>   cool-retro-term (1.1.1+git20210605-1) experimental; urgency=medium
>   .
>     * New upstream version.
>     * Bump standards version to 4.5.1.
> 
> Regards,
> -- 
>    Gürkan Myczko
> 
> 

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: