Bug#988329: RFS: usbredir/0.9.0-1 -- Simple USB host TCP server
Control: tags -1 moreinfo
Hi Lin,
package looks mostly ok; however it needs some brushing up here and there
before an upload :)
Please update the package, remove the moreinfo tag and ping me for an
follow up, and I will take a look again.
On Wed, Jun 16, 2021 at 12:57:29PM +0000, Lin Qigang wrote:
> I changed this package to target experimental because of the code freeze. If I need to do anything else, please let me know. The repository is here https://salsa.debian.org/linqigang/usbredir.
Some review:
- upstream has released 0.10.0 in the meantime.
- compat level is at the ancient level "9". Please consider updating it…
- Standards Version is also quite old. Please consider updating that as well. (see the upgrade checklist
appendix of the Debian Policy)
Some Lintian stuff: (partly already covered above)
W: usbredir source: package-uses-deprecated-debhelper-compat-version 9
I: usbredir source: out-of-date-standards-version 4.2.1 (released 2018-08-25) (current is 4.5.1)
I: usbredir source: public-upstream-key-not-minimal upstream/signing-key.asc has 13 extra signature(s) for keyid 97D9123DE37A484F
I: libusbredirhost1: spelling-error-in-binary usr/lib/x86_64-linux-gnu/libusbredirhost.so.1.0.2 decriptor descriptor
P: usbredir source: insecure-copyright-format-uri http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
P: usbredirserver: manual-page-for-system-command usr/sbin/usbredirserver
P: usbredir source: silent-on-rules-requiring-root
P: usbredir source: trailing-whitespace debian/changelog (line 3)
X: usbredir source: upstream-metadata-file-is-missing
--
Cheers,
tobi
Reply to: