Re: Bug#999802: RFS: libexplain/1.4.D001-12 [QA] [RC] -- library of system-call-specific strerror repl - development files
ons. 17. nov. 2021 kl. 01:18 skrev Adam Borowski <kilobyte@angband.pl>:
>
> On Tue, Nov 16, 2021 at 10:18:12PM +0100, Håvard Flaget Aasen wrote:
> > * Package name : libexplain
> > Version : 1.4.D001-12
>
> > libexplain (1.4.D001-12) unstable; urgency=medium
> > .
> > * QA upload.
> > * Patch: Linux 5.11 no longer has if_frad.h, from Ubuntu. Closes: #997222
> > * Patch: termiox removed since kernel 5.12, from ALT Linux.
> > * Patch: Change from which -> command -v
> > * d/watch: Update to version 4.
> > * Add d/clean to avoid FTBFSx2, from Ubuntu.
>
> Why would you change `which` to `command -v`? The latter is fragile and
> gets a bunch of cases wrong (aliases, shell builtins (there's MANY with
> sh=busybox), non-executable files in $PATH), etc.
>
The reason was 700+ deprecation warnings running the testsuite, so I
thought I would change it sooner rather than later. After reading your
mail I did some more digging, I found #994275 [1] which seems like
"which" will be un-deprecated some time in the future. I should have
looked more closely before changing it.
Regards,
Håvard
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994275#251
Reply to: