Hello Michal, On Fri, 9 Jul 2021 10:29:08 +0200 "Michal Maciola" <m.maciola@samsung.com> wrote:
Just uploaded a fixed package. Please kindly find it for your review.
I see you addressed the first two points, fixing the build itself. Great! - You have specified that your package is native, which would imply that it is written exclusively for Debian. However, this is not the case. You may maintain both upstream and the Debian package right now, but this could change in the future. A more appropriate package format is "3.0 (quilt)", which takes the sources from a particular upstream release and optionally applies Debian-specific patches. There are a number of tools to aid you. Have a look at git-buildpackage, for instance. - Shared libraries are not supposed to be packaged in a single Debian package, but should be separated into the actual shared object and the files required for development only. This is why I asked you to read section 8 of the Debian Policy, where this is explained in more detail. - Please run lintian on your package before uploading. You can ask if you do not understand a particular error, but you will have to fix them anyway. Cheers Timo -- ⢀⣴⠾⠻⢶⣦⠀ ╭────────────────────────────────────────────────────╮ ⣾⠁⢠⠒⠀⣿⡁ │ Timo Röhling │ ⢿⡄⠘⠷⠚⠋⠀ │ 9B03 EBB9 8300 DF97 C2B1 23BF CC8C 6BDD 1403 F4CA │ ⠈⠳⣄⠀⠀⠀⠀ ╰────────────────────────────────────────────────────╯
Attachment:
signature.asc
Description: PGP signature