Bug#987794: RFS: budgie-screensaver/4.0-1 [ITP] -- Screensaver and screen lock for the Budgie Desktop
Control: tags -1 moreinfo
Hi David,
- d/copyright:
- its incomplete; at least the entry for git.mk is missing.
- There are files in src/ that are NOT GPL (e.g. setuid.h)
- (NOTE: I stopped here doing the copyright review. Please make sure to review
it again in depth and fix any issues _before_ the next sponsorship iteration.)
- (optional, but very appreciated): you can tidy up the file a bit by not
repeating the License Texts…
I mean, for example, it's ok to says "License: GPL-2" in the files section and
then have a stand-aline "License: GPL-2" section with the text. This would
improve readability/reviewability a lot…
A small IRL example:
https://tracker.debian.org/media/packages/d/darkradiant/copyright-2.11.0-1
(look for the GPL-2+ and GPL-3+ sections)
- d/docs: the NEWS file should probably be installed as upstream changelog, not
as doc.
- d/rules (optional) I'd prefer to use d/clean instead of overriding dh_clean
- d/control why control.in ? A diff with control shows no dynamic parts in that
file beside the "do not change me" header.
( something to ask upstream): Upstream says "this is GPL-2-only" but this
is contradicted by the headers in e.g src/, which say "GPL-2+". Possibly
upstream might want to rectify that. (Not needed for this upload)
Package needs updating; please remove the moreinfo tag when ready.
--
Cheers,
tobi
Reply to: