Bug#986266: Package Review

To: 986266@bugs.debian.org
Subject: Bug#986266: Package Review
From: Kyle Robbertze <paddatrapper@debian.org>
Date: Thu, 8 Apr 2021 10:27:15 +0200
Message-id: <[🔎] 8886a31b-2ee1-54cc-d11f-82d33c6ec150@debian.org>
Reply-to: Kyle Robbertze <paddatrapper@debian.org>, 986266@bugs.debian.org
References: <[🔎] f5aa42a1-2418-9e80-dc73-62eb43e1cef4@gmail.com>

Control: tags -1 moreinfo

Thank you for preparing the package. I've noticed a couple things thatneed sorting:


debian/changelog:

* The distribution is 'UNRELEASED' - this should be 'unstable'
* Urgency should be 'low'

acme/jws.go, acme/jws_test.go:

* the copyright of this file is not listed in debian/copyright - it iscopyright The Go Authors under a BSD 3-clause licence.


Otherwise it all looks good.

Cheers
Kyle
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze

Reply to:

Follow-Ups:
- Bug#986266: Package Review
  - From: SECOB271_Ganesh Pawar <pawarg256@gmail.com>

References:
- Bug#986266: RFS: golang-github-mholt-acmez/0.1.3-1 [ITP] -- Premier ACME client library for Go (library)
  - From: Ganesh Pawar <pawarg256@gmail.com>

Prev by Date: Bug#979592: RFS: openrct2/0.3.3+ds-1 [ITP] -- Open-source re-implementation of RollerCoaster Tycoon 2
Next by Date: Bug#934515: RFS: golang-github-arduino-go-paths-helper [ITP]
Previous by thread: Bug#986266: RFS: golang-github-mholt-acmez/0.1.3-1 [ITP] -- Premier ACME client library for Go (library)
Next by thread: Bug#986266: Package Review
Index(es):
- Date
- Thread