Bug#979592: RFS: openrct2/0.3.3+ds-1 [ITP] -- Open-source re-implementation of RollerCoaster Tycoon 2
owner 979592 !
owner 985806 !
owner 985807 !
thanks
Hi Mathias,
On 2021-03-24 03:47, Mathias Gibbens wrote:
> retitle 979592 RFS: openrct2/0.3.3+ds-1 [ITP] -- Open-source re-implementation of RollerCoaster Tycoon 2
> thanks
>
> I have uploaded a revised version of openrct2 to mentors.d.n:
>
> dget -x https://mentors.debian.net/debian/pool/contrib/o/openrct2/openrct2_0.3.3+ds-1.dsc
>
> Packaging changes since my previous upload can be viewed on salsa:
> https://salsa.debian.org/gibmat/openrct2/-/commit/5856cfd2595580d4873b71c4dbfa7955729ecebd
>
> I have also started two related RFS bugs for openrct2-objects and
> openrct2-title-sequences:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985806
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=985807
I will happily sponsor all three packages. I have cloned out your
packaging repositories and gave the packaging a look. There are a couple
minor issues:
1. In debian/upstream/metadata, Bug-Database value has to be an URL.
Most likely these will be GitHub issue trackers, in particular, links
ending with '/issues' (spotted in openrct2-objects).
2. In debian/upstream/metadata, Bug-Submit value has unneeded '/choose'
(spotted in openrct2-objects).
3. Upstream copyright entry in debian/copyright lacks years. If the
upstream do not limit their copyright in years, I usually take the year
range spanning commits in the upstream Git repository (spotted in
openrct2-objects).
4. In debian/rules of openrct2-title-sequences, there is a hard-coded
upstream version of the package. This may easily get forgotten when
packaging new upstream versions. I suggest replacing the hard-coded
version with $(DEB_VERSION_UPSTREAM) from /usr/share/dpkg/pkg-info.mk,
see [1] for example.
You have indicated that you are going to be the sole maintainer for the
packages, which is OK. But have you considered team-maintaining your
packages in Debian Games Team? Team maintenance has its advantages, for
example, team members would be able to commit and upload the packages
fixing bugs and uploading new upstream versions. But of course the
choice to team-maintain or not is yours.
[1] https://sources.debian.org/src/byteman/4.0.12-2/debian/rules/
Best,
Andrius
Reply to: