Tobias Frost left as an exercise for the reader:
--
thanks for the feedback, Tobias. responses inline.
> - d/changelog
> The changelog entries for 1.7.6+dfsg.1-2 is different that the one in currently in the archives.
> Please make sure that your packaging repository is in sync with the archives and matches it bit per bit.
> See below for a (shortened) diff. [0]
synced, thanks
> - d/control
> There are many versioned B-Ds. Please check if the version constraints can be dropped
> (they can if oldstable has the version already) [nitpick]
alas, the only one that seemed able to be removed/relaxed was
indeed cmake, from 3.16 to 3.14. i checked the others, and most
have older versions in oldstable. it is of course possible that
notcurses builds/runs properly with these older versions, but i
have no assurance of that.
> S-V is only 3 digits, the 4th digit is not recorded, as it only denotes editorial changes. [nitpick]
Policy Version 4.5.0.3 section 5.6.11:
"either these three components or all four components may be specified."
I have truncated it in the spirit of good comradely fellowship.
> - the lintian overrides for "groff-message" are causing:
> I: notcurses-bin: unused-override groff-message
Yep. See the comment immediately above it and
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/182
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973313
It's a question of having mentors complain to me, or
salsa+lintian complain to me.
> - *.install: instead of usr/lib/*/, with compat 13, you should write
> usr/lib/${DEB_HOST_MULTIARCH}/
done, thanks.
> - d/copyright, Files-Excluded
> Yes, you can have multiline Files-Excluded, so you can wrap the wrong line.
> (example at [1])
You link to tracker.debian.org. I cannot now (and do not recall
ever being able to) resolve this name.
[schwarzgerat](0) $ dig +short tracker.debian.org
;; connection timed out; no servers could be reached
[schwarzgerat](9) $
> - *.install [bikeshed]
> Not sure if TERMS.md, OTHERS.md and CONTRIBUTIONS.md should be installed into the library
> package, as the information within is not really applicable for users of the library.
> Does TERMS.md has a relation to notcurses or is it general information? If it relates,
> maybe the -dev packge or a (see below) -doc package?
> OTHERS.md, if installed, should go to the -dev package (but I think it is not useful,
> as it just lists alternatives.)
> The best place for CONTRIBUTIONS.md is the source package. I wouldn't install it in
> binary packages.
Rather than bikeshed which package these <4k files ought go in,
I've just removed them. README.md is still installed in
libnotcurses2. Thanks.
> - As you seem to have doxygen support, maybe generate html docs and have a dedicated
> libnotcursed-doc package? [bikeshed]
I don't think the doxygen output is useful enough to package,
and certainly don't want to possibly trigger further round-trips
for this content. Thanks though!
> I hope this review helps a bit. Thanks for your contributions to Debian!
Indeed, appreciated.
--
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.
Attachment:
signature.asc
Description: PGP signature