Control: tags -1 moreinfo Control: reopen -1 On Thu, Sep 24, 2020 at 09:29:58AM +0200, Alec Leamas wrote: > Hi again, > > On 24/09/2020 09:07, Alec Leamas wrote: > > > >> "/usr/lib/i386-linux-gnu/pkgconfig" > > > I have made a new upload, only changing the last reference. Will make a > > comment on mentors once it's ready. > > > >> However it builds fine even after changing it, so I presume this DPKGCONFIGDIR is just not used... > > > > > > It's minor mess, basically about the first patch which is too > > heavy-handed. > > > > I have made a new patch series for the build files which I will try to > > upstream. Yeah, had the same thoughts about the build system… (My bikeshed color'd be to use ctest, as they are using cmake already, this feels like a good match) > > The idea is to use it in next release, whether accepted or > > not. However, this is a major change which we should probably avoid at > > this point, just clearing the 1386 issue. Agree. > The new version is available on mentors (#3). Confirmed, it is building. It builds now and the pkconfig file looks also ok. (* on a freshly updated i386 pbuilder env) (Looking at the -dev package: they use a quite common filename (serial.h) without subdirectory in /usr/include. I wonder if there are collisions in the archvie…) > I have considered using 'make -C obj-*' instead of 'make -C > obj-$(DEB_HOST_GNU_TYPE)'. It's simpler, but perhaps too simple (?) Could work, as we're not building for multiple archs at the same time… - Typo in d/changelog: s/FTBS/FTBFS/ - Please add the patch I sent in #970712#39… -- tobi
Attachment:
signature.asc
Description: PGP signature