[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#969180: RFS: facerec/1.0 [ITP] -- A Face Authentication system for ubuntu



Control: tags -1 wontfix

Hi,

I did some time ago look at your package, but did not respond to this bug.
Unfortunatly there are significant problems:

- everything you do in preinst must be done at build time.
- everything you do in postinst. must be done at build time.
  - especially you must not use pip in postinst.

- face_recognition_models is pulled in via pip; it has problems 
as it contains non DFSG data [1] making it unsuitable for Debian main.
(Maybe the offending model could be removed…)

[1] https://github.com/ageitgey/face_recognition_models/issues/10

As said, you cannot get stuff from the Internet when installing a deb package.
(You cannot also during build. The pulled in resources need to be packaged as
well).

Marking it as wontfix [2], as there is a lot to be fixed before a deeper review
makes sense.

Please read carefully 
- the introduction for new maintainer [3] and 
- as you are upstream the Upstream Guide [4].

[2] https://wiki.debian.org/Mentors/BTS#Tags
[3] https://mentors.debian.net/intro-maintainers/
[4] https://wiki.debian.org/UpstreamGuide

When you have a new package, remove the wontfix tag to signal readyness for
review.

(Disclaimer: I do not intent to sponsor this package, I don't know enough about pam and this package has possible security implications…)

Cheers,
--
tobi

Note: I do


Reply to: