[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#969241: RFS: hydrapaper/1.12 [ITP]] -- sets desktop wallpaper on different monitors



Control: tags -1 moreinfo
Control: owner -1 !

Hi Francisco,

On Tue, Sep 08, 2020 at 06:42:23PM -0300, Francisco M Neto wrote:

(Note: I'm removing stuff from the that have been resolved, to keep it short)
- new upstream version 2.0
- dep3 header of patch
- extra B-D on cmake
- d/watch updated
- d/copytright partially fixed.
- nitpicks about lintian overrides fixed.
- orig tarballs shasum now matching with the on on mentors.

> On Tue, 2020-09-08 at 22:01 +0200, Tobias Frost wrote:
> > Control: tags -1 moreinfo
> > 
> > Hi Francisco,
> > 
> > d/copyright:
> > - 1st files section says License: GPL3+, but License text says "Version 2" at
> > two locations.

It still has stray version 2 in the version 3 text… Look at line 17 and 29.

New stuff I found:
d/rules:
- the dh_auto_clean override is not needed. This can be done by listing the files
to be deleted in d/clean.
- Calling dh_clean in an override for dh_*auto*_clean is not correct, you need
  to match those.
--> go for d/clean and delete the override.

Copyright review: ✔

Please fix the remaining issues and then ping me.

-- 
tobi

Attachment: signature.asc
Description: PGP signature


Reply to: