Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Hi,
Thanks for your review :)
Le 26/08/2020 à 12:39, Tobias Frost a écrit :
> Control: tags -1 moreinfo
>
> Hi Alexis,
>
> this is an incomplete review, 'cause I ran out of time, lunch break was not long
> enough :-(
>
> - This should be not an NMU but an QA-Upload so you need to Set the maintainer
> to the QA group, as explained here:
> https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning-a-package
>
> [...]
Ok, I've put sources with imported debsnap history in https://salsa.debian.org/debian/aqemu.
>
> - "(For: #957003)"
> Please close the bug in the changelog; it can always be reopened if it fails
> again…)
Ok
>
> - I'm not sure about dropping the Depends on qemu entirely. Does aqemu work
> without qemu installed? If not, you probably need to follow the recommendation
> in #966261
> and add a Depend on qemu-system-XXX | qemu-system-XXX | … (listing all archs).
>
I'm wondering if I should put these as a Recommends instead.
I'm thinking about cases where someone would want to use a different qemu not packaged,
like a custom one or a manually compiled one.
But I'm not sure I should handle these cases, what do you think ?
>
> There were other bugs on the packages too. Did you try to triage them?
> (It would be nice to at least report them to upstream, but that's not a show
> stopper for the sponsoring)
I'm not using aqemu myself, but some of them or probably upstream, and maybe fixed
since they were reported, but newer versions (0.9.6+) are qualified as not yet
stable by upstream.
I will see if they were already reported or still relevant
(some of them were created in 2012).
>
> Many thanks for contributing to Debian!
>
Thanks for your review :)
--
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC 2787 E7BD 1904 F480 937F
Reply to: