[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965363: Fwd: Bug#965363: RFS: opencpn/5.2.0+dfsg-1 [RC] -- Open Source Chartplotter and Marine GPS Navigation Software



On Sun, Sep 13, 2020 at 01:23:41PM +0200, Alec Leamas wrote:

(snipping stuff that is done or settled … Its getting a long mail)

(regarding the transitinal package and Replace/Breaks versioning)
> OK, will do (unless not done in a MR)

MR sent. (https://gitlab.com/leamas/opencpn/-/merge_requests/2) For the readers:
- Replace/Break on << 4.8.8~. The ~ ensures that it matches everything that had
  4.8.8 in it. (where the change happened)
- The transistional package will no longer be built.

Note that I did not add d/changelog entries; left to you; no need to mention me.

> d/rules: (...)
MR sent. (https://gitlab.com/leamas/opencpn/-/merge_requests/1)
The MR tidies up d/rules (removing the need for override_dh_auto_install) by replacing
the logic with declratavie syntax:
- installing the manpages not via dh_install but with dh_installman.
- using dh_link to build the symlinks to the GPL licenses needed by the programm.
- be more accurate in d/*install what to install
- use the possiblity to move files around in d/*install
- specify the files not to be installed. (d/not-installed)

Regarding the licenses symlinked: Are they acutally used. grep did find nothing for me…
In this case, the file d/opencpn.links should be removed

Please review the changes to the (not-)installed (especially d/opencpn-dat.ionstall as
you know whether the programm expect those. (After a simply grep I assumed it does not.)

Please note that there will be an build error I left intentionally:
It does not install CoC-909_2013-InlandECDIS_20170308s.pdf because this file is a file
- without source (and so also not built from source)
- unclear license (I don't think that is under a DFSG license… Is it distributeable?)
atm it looks like it needs to be removed via Files-Excluded.

Also no d/changelog entries; left for you to be done… (I do _not_ need credit for those!)

So far for now…


Reply to: