[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#964308: RFS: geshi/1.0.9.1-1 [ITA] -- Generic Syntax Highlighter



Control: tags -1 moreinfo

On Sun, Jul 05, 2020 at 07:15:01PM +0800, Nick Gasson wrote:
>...
> Changes since the last upload:

Looks good, except:

>...
>      - Update debhelper compatibility level to 13.

-Build-Depends: cdbs, debhelper (>= 9)
+Build-Depends: debhelper (>= 9), debhelper-compat (= 13)

On the nitpick side is that debhelper-compat (= 13) is sufficient.

Slightly more serious that you should document the switch from cdbs in 
the changelog.

>...
> +  * debian/tests/test.php: add a simple sanity test.
>...

Is anything running this test?
This looks like an autopkgtest without the control file.


More a question is whether the Homepage in debian/control still points 
to the best place. The current URL points to an outdated location.


> Regards,

cu
Adrian


Reply to: