Bug#968504: RFS: aqemu/0.9.2-2.4 [NMU] [RC] -- Qt5 front-end for QEMU and KVM
Control: tags -1 moreinfo
Hi Alexis,
this is an incomplete review, 'cause I ran out of time, lunch break was not long
enough :-(
- This should be not an NMU but an QA-Upload so you need to Set the maintainer
to the QA group, as explained here:
https://www.debian.org/doc/manuals/developers-reference/pkgs.html#orphaning-a-package
As this is a QA upload, you can also fix other stuff in the package more freely,
like the quite outdated standards version, compat level and other stuff lintian
complains about. (This would be at least nice to have, its no show stopper for
the sponsoring.)
It would be also cool to have this package in git on salsa.debian.org.
I can create a repo for you and give you access to it, if you want, just
give me your salsa username and I'll do the clicking…
(I'll populate the repo using gbp import-dscs --debsnap so that
the history of the package is somehow retained.)
- "(For: #957003)"
Please close the bug in the changelog; it can always be reopened if it fails
again…)
- I'm not sure about dropping the Depends on qemu entirely. Does aqemu work
without qemu installed? If not, you probably need to follow the recommendation
in #966261
and add a Depend on qemu-system-XXX | qemu-system-XXX | … (listing all archs).
There were other bugs on the packages too. Did you try to triage them?
(It would be nice to at least report them to upstream, but that's not a show
stopper for the sponsoring)
Many thanks for contributing to Debian!
Cheers,
tobi
On Sun, 16 Aug 2020 16:13:29 +0200 Alexis Murzeau <amubtdx@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: important
> X-Debbugs-CC: Ignace Mouzannar <mouzannar@gmail.com>
>
> Dear mentors,
>
> I am looking for a sponsor for a NMU of "aqemu" to fix this RC bug:
> #957003 - aqemu: ftbfs with GCC-10 [0]
>
> And these additional bugs:
> #966261 - please drop `qemu' from Depends [1]
> #874050 - aqemu depends on meta-package qemu, which pulls in all supported
emulation architectures [2]
>
> The maintainer has not responded to this bug, nor other bugs on
> this package and orphaned the package in #955988.
>
> This NMU :
> - Add a patch to fix the build issue with GCC 10
> - Remove the dependency on "qemu" dummy package to let it be removed.
> - This is not a RC bug, but I deemed the ratio usefulness/impact
> to be high enough to include it with the fact that the package is
orphaned.
> Let me know if this should be avoided anyway.
>
> I'm in the process to try to put this package under the Debian group on Salsa
when
> I will be able to retrieve all available VCS histories from Ignace to keep
them on Salsa.
> But that's not ready yet.
>
>
>
> * Package name : aqemu
> Version : 0.9.2-2.4
> Upstream Author : Andrey Rijov, Tobias Gläßer
> * URL : https://sourceforge.net/projects/aqemu/,
> https://github.com/tobimensch/aqemu
> * License : GPL-2+, BSD-3-clause
> Section : x11
>
> It builds those binary packages:
>
> aqemu - Qt5 front-end for QEMU and KVM
>
> To access further information about this package, please visit the
> following URL:
> https://mentors.debian.net/package/aqemu
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x
> https://mentors.debian.net/debian/pool/main/a/aqemu/aqemu_0.9.2-2.4.dsc
>
> Changes since the last upload to unstable:
> aqemu (0.9.2-2.4) unstable; urgency=medium
>
> * Non-maintainer upload.
> * debian/patches/0003-Fix-build-with-GCC-10.patch:
> - Fix build with GCC 10 (For: #957003)
> * debian/control:
> - Drop qemu dummy package from Depends (Closes: 966261, 874050)
>
Reply to: