On Thu, May 14, 2020 at 12:35:02PM +0800, 铜豌豆 Linux wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "lunar-date" > > * Package name : lunar-date > Version : 2.4.0-6 [snip] > dget -x > https://mentors.debian.net/debian/pool/main/l/lunar-date/lunar-date_2.4.0-6.dsc Hi, A couple of issues here, some minor, some not so much... > Changes since the last upload: > > [ 肖盛文 ] > * d/copyright: > + Add xiao sheng wen <atzlinux@sina.com> as Uploaders. > + use https for Source. > * d/watch: add https for url > * d/rules: > + delete override_dh_missing > + delete override_dh_strip > + delete export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed > * d/control: > + Bump debhelper-compat (= 13) > + Bump Standards-Version: 4.5.0 > + add https to Homepage url > + add new Uploader xiao sheng wen <atzlinux@sian.com> > + add Multi-Arch: > * fix litian: typelib-not-in-multiarch-directory You have a typo here, ITYM "lintian" :) > * add liblunar-date-2.0-0.symbols > * fix lintian: gir-section-not-libdevel > move LunarDate-2.0.gir from gir1.2-lunar-date-2.0 to liblunar-date-dev > * add lintian overrides for packagename > * add gir1.2-lunar-date-2.0.NEWS Now the not so trivial issue: it seems to me that you changed the debian/gir1.2-lunar-date-2.0.install file and made it install the library explicitly into a directory named "usr/lib/x86_64-linux-gnu/girepository-1.0/" - this will not work in multiarch, or at least, it will not produce the result you want :) If you create, say, an i386 sbuild chroot and build your package in it, you'll see that the library and dev packages install their files properly into usr/lib/i386-linux-gnu/, but the gir1.2-lunar-date-2.0 package installs the typelib file into usr/lib/x86_64-linux-gnu. What do you think about the attached patch that fixes this and the related Lintian override? Minor suggestions: - since debhelper 11, the dh-* helper packages may "Provide: dh-sequence-something" and the packages that use them, like yours, may have dh-sequence-something as a build dependency; then debhelper will assume that you mean "dh --with something". Thus, you may drop the "--with gir" from the rules file and add "dh-sequence-gir" as a build dependency - you may want to update your watch file to version 4 and use variables :) - you may switch to an execute_before_dh_install target - in the rules file, you may append to CFLAGS using DEB_CFLAGS_MAINT_APPEND instead of overriding the full value Thanks for your work! G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@debian.org pp@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
diff -urN lunar-date-2.4.0/debian/gir1.2-lunar-date-2.0.install lunar-date/debian/gir1.2-lunar-date-2.0.install --- a/debian/gir1.2-lunar-date-2.0.install 2020-05-14 06:59:29.000000000 +0300 +++ b/debian/gir1.2-lunar-date-2.0.install 2020-05-14 11:33:08.797763000 +0300 @@ -1 +1 @@ -usr/lib/*/girepository-1.0/* usr/lib/x86_64-linux-gnu/girepository-1.0/ +usr/lib/*/girepository-1.0/* diff -urN lunar-date-2.4.0/debian/gir1.2-lunar-date-2.0.lintian-overrides lunar-date/debian/gir1.2-lunar-date-2.0.lintian-overrides --- a/debian/gir1.2-lunar-date-2.0.lintian-overrides 2020-05-14 06:59:29.000000000 +0300 +++ b/debian/gir1.2-lunar-date-2.0.lintian-overrides 2020-05-14 11:35:58.270707899 +0300 @@ -1 +1 @@ -gir1.2-lunar-date-2.0: typelib-package-name-does-not-match usr/lib/x86_64-linux-gnu/girepository-1.0/LunarDate-2.0.typelib gir1.2-lunardate-2.0 +gir1.2-lunar-date-2.0: typelib-package-name-does-not-match usr/lib/*/girepository-1.0/LunarDate-2.0.typelib gir1.2-lunardate-2.0
Attachment:
signature.asc
Description: PGP signature