[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#950824: RFS: sayonara/1.5.2-beta3~1 -- Small and lightweight music player



some fix is done.

E: sayonara: \python-script-but-no-python-dep\ usr/bin/sayonara-ctl #!python3
E: sayonara: \python-script-but-no-python-dep\ usr/bin/sayonara-query #!python3

update version is "sayonara_1.6.0~exp1"

also add source dependency to
               dh-python,
               doxygen,
               taglib,
               python3:any
and package dependencies 
                 doxygen,
                 libtagc0,libtag1v5,libtag1v5-vanilla,
               ${python3:Depends},
for 
E: sayonara: \embedded-library\ usr/bin/sayonara: taglib

taglib dependency still check in CMake


with regards. 






On Sat, Feb 8, 2020 at 12:47 AM Boyuan Yang <byang@debian.org> wrote:
Hi,

在 2020-02-07五的 11:14 +0630,Ko Ko Ye`写道:
> I am looking for a sponsor for my package "sayonara"
>
> Sayonara is a small, clear and fast audio player for Linux written in C++,
> supported by the Qt framework.
> It uses GStreamer as audio backend. Sayonara is open source and uses the
> GPLv3 license.
> more at https://sayonara-player.com [1],
> https://gitlab.com/luciocarreras/sayonara-player [2]

Could you fix those lintian errors?

E: sayonara: \embedded-library\ usr/bin/sayonara: taglib
E: sayonara: \python-script-but-no-python-dep\ usr/bin/sayonara-ctl #!python3
E: sayonara: \python-script-but-no-python-dep\ usr/bin/sayonara-query
#!python3

Besides, the version string is also buggy.
  * The debian revision should be -1 and never be ~1.
  * If upstream is releasing a beta version with version string as "1.5.2-
beta3", you should consider mangling it back to "1.5.2~beta3" since "1.5.2-"
is considered a higher version than "1.5.2" in Debian.

Final result should be "1.5.2~beta3-1". Plese read deb-version(5) man page for
information about Debian's versioning.

Another thing is that you should drop historical changelog entries in
debian/changelog. They are useless in Debian.

--
Thanks,
Boyuan Yang


--

Reply to: