[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#976180: RFS: libzc/0.4.3-1 -- Command line tool for the libzc library



Control: tags -1 moreinfo

Marc Ferland:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> [...]
> 
> Changes since the last upload:
> 
>  libzc (0.4.3-1) unstable; urgency=low
>  .
>    * New upstream release.
>    * New Dockerfile to simplify debian releases.
>    * Removed zc_file_info_offset() function from API.
>    * Added two new functions to the API: zc_file_info_offset_begin() and
>      zc_file_info_offset_end().
>    * ABI change libzc4 -> libzc6
>    * Added the possibility to specify the filenames instead of the
>      offsets in the plaintext cracker in yazc tool.
>    * Added the -S option to the plaintext cracker to print time stats.
> 
> Regards,
> --
>   Marc Ferland
> 

Hi Marc,


I found a few issues I would like to see resolved before I will sponsor
the upload.


Changelog
=========

I see the following changes since 0.4.1-1 that I cannot find documented
in debian/changelog:

 * Rules-Requires-Root has been set to "no"

 * Multi-Arch has been set to same for two binary packages.

 * Standards-Versions has been bumped to 4.5.0

Please document these in the 0.4.3-1 changelog.


_Pedantic_ side note: It is custom to only mention uploads that have
been uploaded in the debian/changelog.  As 0.4.2-1 was never in Debian
unstable (and I presume in no other distro as well given it says
"unstable") then it should have been omitted.

SONAME bump
===========

The library changes SONAME and there is no mention of it.  This requires
a transition if the package has reverse dependencies, but there is no
comment from you on whether you have started the relevant transition
procedures or that they are irrelevant because your package has no
reverse dependencies in unstable and testing.


In #902476, I have exempted you from some of these requirements
previously on the basis that I wanted you to do them correctly next time
(which would be now). :)

~Niels


Reply to: