Control: tags -1 moreinfo Hi Laurin, Here's a review on your package; it needs some more work, please remove the moreinfo On Fri, Oct 30, 2020 at 09:52:34PM +0100, Laurin Hagemann wrote: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "liboauth": > > * Package name : liboauth > Version : 1.0.3-4 > Upstream Author : Robin Gareus <robin@gareus.org> > * URL : http://liboauth.sourceforge.net/ > * License : Expat > * Vcs : https://salsa.debian.org/debian/liboauth > Section : libs > > It builds those binary packages: > > liboauth0 - C library implementing OAuth Core 1.0a API (runtime) > liboauth-dev - C library implementing OAuth Core 1.0a API (development files) > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/liboauth/ > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/libo/liboauth/liboauth_1.0.3-4.dsc > > Changes since the last upload: > > liboauth (1.0.3-4) unstable; urgency=medium > . > * Fix lintian warnings > * Bump debhelper version That's a terse changlog… You should expand a bit more, the changelog should give an idea what have been changed and why. Looking at the diff between the version in the archives (1.0.3-4) and on mentors, not all changes are documented, but they need to be: - you are adopting the package. (a big thanks for that!) (That should close a orphaning bug. Strangely there is none. [0]) - You are downgrading the Standards-Version from 4.5.0 to 4.3.0, this is some kind of unexpected change, possible unintended? I could not think of a reson for that, but if you have one, that needs documentation in the changelog. The "bump debhelper version" is not done correctly. For one, it should be "compat level bump, and one bumps it by changing the version on debhelper-compat, not by adding a debhelper build-depends. And, thecurrent debhelper compat version is 13, not 12. I wonder if you have based your work on some old package? Well, Now I see it: You d/changelog is for 1.0.3-4, the same as in the archives; so you seem have to based your package on the wrong version. Another change is adding gbp.conf (undocumented as well) with different branch names. That only can be done when also the brances be renamed on sasla. [0] I did file one now, the bug number is: #973473. If you want to adopt the package, you need to indicate that on that bug as documented here: https://www.debian.org/doc/manuals/developers-reference/pkgs.html#adopting-a-package and https://www.debian.org/devel/wnpp/ --> you need to change the title to an ITA type and set the owner of that bug to yourself. With bts(1) it would be bts retitle 973473 "ITA: liboauth -- C library implementing OAuth Core 1.0a" , owner it ! -- Cheers, tobi
Attachment:
signature.asc
Description: PGP signature