[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#966253: RFS: devtodo/0.1.20-8 [QA] -- hierarchical, prioritised todo list manager



On Thu, Aug 27, 2020 at 11:47:30PM -0300, Carlos Henrique Lima Melara wrote:
> Hi, Adrian.

Hi Charles,

please always Cc people in the BTS, except for the maintainer noone gets 
automatically subscribed.

> On Thu, 27 Aug 2020 11:41:48 +0300 Adrian Bunk <bunk@debian.org> wrote:
> > Looks good, except:
> > 
> > >    * debian/rules: replaced override_dh_auto_install with dh_bash-completion
> > >      for the installation of bash-completion code.
> > >...
> > 
> > This is not the correct name for the installed file:
> > /usr/share/bash-completion/completions/devtodo.bash-completion
> 
> I think that the phrase just looks a bit confusing (my bad). What
> I meant is replaced override_dh_auto_install with dh_bash-completion
> addon.

But it isn't doing the same.

What I meant is that debdiff says when comparing 0.1.20-7 with 0.1.20-8:

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /usr/share/bash-completion/completioins/devtodo

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   /usr/share/bash-completion/completions/devtodo.bash-completion

Your change fixes the typo in the directory name (good),
but it installs the file with the wrong name (bad).

> Also I'd like to apologize to you because another sponsor talked
> to me about this package through instant messaging. I'm terribly
> sorry cause I've changed the "need sponsor" on mentors website but
> forgotten to close the rfs or to inform in the bug.

No problem with that, happy to hear you have someone else to sponsor it.

> Cheers,
> Charles

cu
Adrian


Reply to: