[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#964164: Bug#947017: Bug#964164: RFS: org-drill/2.7.0-1 [ITP] -- spaced repetition drills in Emacs for accelerated study/learning



Thank you Nicholas for the reminder and sorry for keeping you waiting.

Unfortunately, I don't believe the package would pass the NEW queue in its current state. You did remove the apple.jpg file but you added a new apple.png file that is not mentioned in debian/copyright.

I know how annoying these copyright issues are!

I think the easiest would be to just remove the file and its references without any replacement. You might then help upstream with a pull request to provide a dfsg free picture for the next version.

The following remarks are maybe not strictly required:

Even if you add a new file, you should not use debian/patches to add it but just include it in the debian tarball. I actually never had to do this myself, so I have no experience with adding a binary file.

Please also add a version number to dfsg suffix like dfsg1 or dfsg-1. It happened to me before that I needed multiple uploads to the new queue before I found all non dfsg-unfree files: https://tracker.debian.org/pkg/nix

Especially the version number of the orig tarball is different from the changelog. I wonder how this worked in the first place.

If you want to reflect the dfsg cleaning work also in your git packaging branch, I started a knowledge base article  here:
https://wiki.debian.org/kb/git_packaging_dfsg_clean_branch
An example of this: https://salsa.debian.org/debian/nix

My nix package also contains a debian/watch example to produce a dfsg clean orig tarball.

The git packaging repo does not contain the latest commits apparently, there is no debian/patches folder:
https://salsa.debian.org/emacsen-team/org-drill/-/tree/master/debian

Thank you very much for your contribution and especially for your patience!


Reply to: