[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#965018: RFS: freetype-py/2.2.0-1 -- Freetype Python bindings for Python 3



On 2020-07-29 23:45, mattia@debian.org wrote:
On Wed, Jul 29, 2020 at 11:09:37AM +0200, Bastian Germann wrote:
The python3-setuptools-scm build dependency could not be installed in
your environment which causes setuptools to try download this package.
That obviously fails.

Shouldn't pdebuild make sure that all the build dependencies are installed?

I certainly would have expected it to check build dependencies, just as dpkg-buildpackage does.


You are both confusing pdebuild with pbuilder here.

That's the `clean` step that is failing, which is done outside of the
chroot.  That's responsability of whoever is calling `pdebuild` to
satisfy.

If you are sure your source is clean you may as well just skip cleaning
and not use pdebuild:
    dpkg-source -b .
    dpkg-source --after-build .
    pbuilder b ../freetype-py_2.2.0-1.dsc
the above sequence should prove that nothing is at fault here.


But it's more convenient to have the single command pdebuild to use.

It certainly is true that I didn't have python3-setuptools-scm installed. Installing it enables pdebuild to proceed normally.

As you point out, the problem here is in a clean step performed prior to activating the pbuilder chroot. (I presume python3-setuptools-scm would get installed into the chroot, but pdebuild never reaches that step).

It looks to me this is a design flaw in pdebuild itself. It requires build dependencies to be available outside the chroot, which a) somewhat contradicts the entire point of chroot building, and b) doesn't check that those build dependencies are installed anyway.


The problem is not in freetype-py. It's already declared python3-setuptools-scm as a Build-Dependency.


Bastian, the build proceeds (even with pdebuild) if I have python3-setuptools-scm installed on my normal system (i.e. outside the chroot). That's good enough for a pdebuild build.

I notice you've made some edits in the meantime. I think you've fixed lintian warning redundant-globbing-patterns for debian/changelog in commit 4422b3b.

But current git no longer builds (even with dpkg-buildpackage) from changes in freetype-py/setup.cfg (removing [egg_info]). Not sure if it's a consequence of 40db38e.

Since we've got a workaround for the pdebuild problem, I can upload once you've got it back in action.

I'll file a bug against pbuilder about the pdebuild problem.

Drew


Reply to: