[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#962307: RFS: anymeal/1.5-1 [ITA] -- Cookbook database for storing recipes



Hi,

On Sun, 26 Jul 2020 22:58:16 +0100 (BST) Jan Wedekind <jan@wedesoft.de> wrote:
> Hi,
> I have now released version 1.5. It is available here:
> 
>      https://mentors.debian.net/package/anymeal
> 
> Also it can be downloaded as follows:
> 
>      dget -x 
https://mentors.debian.net/debian/pool/main/a/anymeal/anymeal_1.5-1.dsc

Please fix the following issues before we proceed:

1. It looks like your package has nothing to do with KDE. As a result, please
do not use "Section: kde" in debian/control file. Maybe we can use "Section:
utils".

2. Please also document the copyright holder information and different license
information for files under m4/ directory, epecially ax_have_qt.m4 and
ax_lib_sqlite3.m4.

3. Please clean up debian/changelog file and drop all past changelog entries
that never existed in Debian. (They never existed in the past and they won't
exist in the future so they should not appear anyway.) See 
https://tracker.debian.org/pkg/anymeal for the history of package anymeal in
Debian.

4. Can you explain the reason of overriding dh_auto_install in debian/rules
directory? If you are using Autotools buildsystem correctly, you should not do
override at all and the package will build successfully without human
intervention.

The problem 1), 2) and 3) should be fixed and you can feel free to investigate
into 4) if you are willing to. Let me know after those issues are solved.

--
Regards,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: