[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#960397: RFS: oxygencursors/0.0.2012-06-kde4.8-3 [QA] [RC] -- Oxygen mouse cursor theme

Am Di., 12. Mai 2020 um 14:46 Uhr schrieb Adam Borowski <kilobyte@angband.pl>:
> Alas, it fails to build:
> libpng error: Read Error
> /usr/bin/xcursorgen: PNG error while reading 180/pencil.png
> Background RRGGBBAA: ffffff00
> Area 0:0:32:32 exported to 60 x 60 pixels (180 dpi)
> Background RRGGBBAA: ffffff00
> Area 0:0:24:24 exported to 45 x 45 pixels (180 dpi)
> make[3]: *** [theme-yellow/CMakeFiles/theme-yellow.dir/build.make:203: oxy-yellow/cursors/pencil] Error 1
> make[3]: *** Deleting file 'oxy-yellow/cursors/pencil'
> make[3]: *** Waiting for unfinished jobs....
> I haven't investigated the fail, but as "Read Error" could be platform
> related, I tried on three different machines (2×amd64, 1×arm64) -- same.

Thanks for catching this.
It seems with bare cmake `add_custom_command`'s, they might get called
multiple times to generate the specified output. [1]
(So a subsequent generation might conflict with the concurrent usage
of the file.)
So I added a patch introducing custom targets.

> Also: why would you move the section?  This is a properly made theme that
> works with any WM/DE, not just KDE.  I don't know KDE team's policies,
> though, thus this is not a hard request -- feel free to ignore.

My bad, I though section x11 being for xserver related things (but
these cursors also work on wayland), but even weston is in the x11
category; reverted.

[1]: https://samthursfield.wordpress.com/2015/11/21/cmake-dependencies-between-targets-and-files-and-custom-commands/⠀⠀;

Reply to: