Bug#939886: review

[Kyle Robbertze <paddatrapper@debian.org>]

Control: tags -1 moreinfo

Hi,

There are copyright issues with this package:

The upstream author is Jamal Moon, so the copyright file needs to 
reflect their copyright, not yours for Files: *

The homepage should also be upstream's homepage [1] and the watch file 
should point to upstream's releases on GitHub.

[1] https://github.com/jmoon018/PacVim

Also the package is not Lintian clean:

> pacvim: arch-independent-package-contains-binary-or-object usr/games/pacvim\

This package should be arch: any, not arch: all.

> pacvim: unstripped-binary-or-object usr/games/pacvim

> W: pacvim: executable-not-elf-or-script usr/share/pacvim-maps/map0.txt

These files should not be executable

> W: pacvim: missing-depends-line

Need to add ${shlibs:Depends} to the Depends line in debian/control

> W: pacvim: new-package-should-close-itp-bug

Your changelog closes line has two ## in front of the bug number instead 
of one

Further, may want to use build-depends debhelper-compat (=12) instead of 
the debian/compat file.

Cheers
Kyle
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Kyle Robbertze
⢿⡄⠘⠷⠚⠋⠀ Debian Developer
⠈⠳⣄⠀⠀⠀⠀ https://wiki.debian.org/KyleRobbertze