Control: owner -1 !
Control: tag -1 moreinfo
On Thu, Jan 09, 2020 at 09:16:37PM +0000, Sudip Mukherjee wrote:
> dget -x https://mentors.debian.net/debian/pool/main/c/coinor-vol/coinor-vol_1.5.4-1.dsc
reviewing this .dsc, I have to comment on the changelog:
> Changes since the last upload:
>
> * QA upload.
> * Update to upstream v1.5.4
> * Update d/copyright.
Mention that you rewrote it using copyright-format 1.0.
(also, since you did this, I'm going to trust you on it without further
reviewing it for correctness)
> * Rename package based on SONAME major version.
> * Remove dbg package in favor of dbgsym.
> * Mark QA as maintainer.
Rewrite this as "Mark the package as orphaned (see #645082)."
> * Update Standards-Version to 4.4.1
Mention that by doing this you are changing the priority.
> * Update compat level to 12
> * Remove build dependency on cdbs.
> * Simplify d/rules and rework on d/*.
I want more details for this. mention that you moved from cdbs from dh
(I think it's good that after this you drop the line above).
For example, it's important to say that you added a .symbols file.
> * Update Vcs to salsa.
> * Mark source format as 3.0
> * Add Rules-Requires-Root: no
Also, you did this:
+override_dh_auto_configure:
+ ./configure --prefix=${PREFIX} --includedir=${PREFIX}/include --mandir=${PREFIX}/share/man --libdir=${PREFIX}/lib/${DEB_HOST_MULTIARCH} --enable-static --with-dot COIN_SKIP_PROJECTS="Osi CoinUtils OsiVol Sample"
why not using dh_auto_configure?
for this instead:
+override_dh_autoreconf:
use `--without autoreconf` on the dh line.
and
+LDFLAGS += -lm
please read dpkg-buildflags(1) and follow what it says.
I'd rather have these done now, rather than in a subsequent upload. In
the next upload you can take care of the duplicate-short-description :P
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature