On Monday, August 26 2019, Fabian Wolff wrote: > On 8/27/19 12:20 AM, Sergio Durigan Junior wrote: >> On Monday, August 26 2019, Fabian Wolff wrote: >> >>> Dear mentors, >>> >>> I am looking for a sponsor for a QA upload of the dbacl package. >>> >>> This upload attempts to fix a FTBFS bug (#916182), and I have also performed some standard package maintenance tasks. >>> >>> I will push to the proper repository (in the Debian group on Salsa) as >>> soon as I have the required permissions on Salsa; in the meantime, you >>> can find my changes here: https://salsa.debian.org/wolff-guest/dbacl >>> >>> And also on Mentors: https://mentors.debian.net/package/dbacl >> >> Hm, I wasn't able to generate the orig tarball; maybe you forgot to push >> the pristine-tar branch? > > No, I forgot to add --pristine-tar when doing gbp import-orig, and I > don't know how to do it retroactively; I guess that whoever imports > the next upstream version can create the branch (or somebody more > knowledgeable about git-buildpackage can do it now for the current > version). Ah, fair enough. >> While at it, please follow the standard being used to organize the build >> deps (1 item per line): >> >> + flex, bison >> >> Out of curiosity, why do you have to regenerate the parser/lexer files? > > Hm, somebody else already uploaded the package now, so I can't change it anymore for this upload. Hm. Second time today. I wish we had a better way to sync this. > As for why I have to regenerate the lexer and parser, I think some of > the arguments from [0] apply, but in particular, just including > <locale.h> in dbacl.h did not fix the FTBFS issue; I actually had to > regenerate the lexer and parser for my changes to take effect (or > maybe I just made a mistake somewhere - I don't have much experience > with flex/bison). Ah, I see. Thanks for explaining. > In any case, thank you very much for having a look at my changes (and also for creating the Salsa repositories!). My pleasure. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature