Hi Adam, On Sun, 5 May 2019 13:46:57 +0200 Adam Borowski <kilobyte@angband.pl> wrote: > On Sat, May 04, 2019 at 04:08:32PM -0700, Lev Lazinskiy wrote: > > I am looking for a sponsor for my package "megadown" > > > > * Package name : megadown > > Version : 0~20190502+git734e46f-1 > > > Changes since the last upload: > > > > * New upstream release (Closes: #927462) which is an RC bug. > > * Remove patch series. Upstream swapped out python for jq. Python is no longer > > required > > * Add jq as dependency > > Hi! > This is a non-maintainer upload, and you don't seem to have followed the > usual rules. Also, during a freeze, only small targetted fixes are > appropriate -- this is a bulk new upstream version. There are cases when > there's no better way than such a large upload (like Firefox and Chromium > these days), but as the patch fixing #927462 is tiny and obvious (although > I don't know if it's enough), it strongly seems the large upload is not > needed. > > Thus, could you please extract (and test) just the fix? Only if that > doesn't work we could debate uploading the whole new upstream version. > > Also, although a RC bug that hasn't seen maintainer response within two > weeks is eligible for a 0-day NMU, you'd still need to follow at least parts > of the procedure. Especially, the upload needs to be marked appropriately: > the first line of the changelog should say "Non-maintainer upload.", the > version needs to be .1, etc. NMUs are supposed to be small which is similar > to during-freeze updates. > > (Even if such a procedure might seem like an unnecessary hurdle, it doubles > as a way to ensure you are aware what you're doing.) Thank you very much for all of this great feedback. This was my first time attempting to update a package. I don't necessarily use or need this package, but the fix seemed simple enough so I gave it a shot to try to help out with the RC Bug. It looks like the RC bug was already resolved by another NMU. I really appreciate the additional direction that you provided and I will keep this in mind for the future. > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8" > ⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs? > ⠈⠳⣄⠀⠀⠀⠀ > > -- Lev Lazinskiy https://levlaz.org e: lev@levlaz.org
Attachment:
signature.asc
Description: This is a digitally signed message part