Bug#920039: RFS: brightness-controller/2.2.3 [ITP]
On Tue, Jan 22, 2019 at 07:54:45PM +0530, Archisman Panigrahi wrote:
> On Tue, Jan 22, 2019 at 5:41 PM Adam Borowski <kilobyte@angband.pl> wrote:
>
> > On Tue, Jan 22, 2019 at 04:57:20PM +0530, Archisman Panigrahi wrote:
> > > I am not sure about the native package issue. Has it got something to
> > > do with /debian/source/format? I did not exactly understand what is
> > > the difference between native and quilt, so went for native. Any
> > > suggestion is welcome.
> >
> > The "native" format is adequate only when there's no separate upstream (and
> > often not even then); in this case you are packaging Amit's software that
> > has proper releases, tarballs, and all proper trappings.
> >
> > The packaging is supposed to be composed of two pieces:
> > * the upstream (.orig) tarball
> > * a packaging tarball, that includes the debian/ dir and a (possibly empty)
> > patch series
> >
> > This was somewhat different with the 1.0 format, but you don't want it --
> > even if you (like me) despite quilt, the "3.0 (quilt)" format with a single
> > patch is strictly better than 1.0.
>
> I am now using 3.0 (quilt). I have uploaded a new release (under the same
> version number), please check.
> There is some lintian error
> "debian-changelog-version-requires-debian-revision". Is it due to the fact
> that the debian/changelog in .orig.tar.gz
Lintian has a nice set of explanations for its error messages, they get
enables by "-I". These tend to be better than one-paragraph responses
reviewers like me reply with (even though an automated tool is not as good
at understanding the context).
In this case, the version number should end in "-1".
> init.py calls other python files in usr/share/brightness-controller/ui and
> usr/share/brightness-controller/util, so I want init.py
> to be in usr/share/brightness-controller/ as well. Otherwise I will need to
> import them across directories which I want to avoid.
That's a Python specific question, I can't answer those. I'm afraid that I
need to pass you to other people on this mailing list. If you happen to
have any Perl questions, though...
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Remember, the S in "IoT" stands for Security, while P stands
⢿⡄⠘⠷⠚⠋⠀ for Privacy.
⠈⠳⣄⠀⠀⠀⠀
Reply to: